`/eth/v2/beacon/pool/attestations` does not honor `committee_index`

[mcdee]

If the /eth/v2/beacon/pool/attestations endpoint is passed no committee_index then it returns attestations from all committees.

If it is passed committee_index=0 it returns attestations from all committees.

If it is passed committee_index=n for any n>0 it returns nothing.

These last two situations are non-spec and I believe are bugs.

lighthouse --version
Lighthouse v7.0.0-beta.5-6d5a2be
BLS library: blst-portable
BLS hardware acceleration: true
SHA256 hardware acceleration: true
Allocator: jemalloc (4K)
Profile: maxperf
Specs: mainnet (true), minimal (false), gnosis (true)

[michaelsproul]

Yep good catch.

This filter needs updating:

lighthouse/beacon_node/http_api/src/lib.rs

Lines 1880 to 1885 in bf955c7

	let query_filter = |data: &AttestationData| {
	query.slot.map_or(true, |slot| slot == data.slot)
	&& query
	.committee_index
	.map_or(true, |index| index == data.index)
	};

We'll need to change the closure type to take &Attestation rather than &AttestationData so we can access the committee index post-Electra.

Needs a regression test too in the HTTP API crate.

[eserilev]

im on it

[eserilev]

Closed in #7298