-
Notifications
You must be signed in to change notification settings - Fork 887
Remove TTD flags and safe-slots-to-import-*
#6489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
safe-slots-to-import-*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to comment on the files directly but there's a few more references to safe_slots
in the consensus/types/presets
files and also book/src/api-vc-endpoints
that I think we can remove.
Updated thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a732a87 |
* Delete SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY * Update fork choice tests * Remove TTD related flags * Add deprecation warning * Remove more dead code * Delete EF on_merge_block tests * Remove even more dead code * Address Mac's review comments
Proposed Changes
Start deleting some merge logic and flags. We don't need to carry this stuff around forever.
SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY
. This concept was removed from the spec, so this was just dead code.Ripping out the TTD logic more thoroughly proved to be more involved. A lot of our tests still depend on doing the merge transition, which is annoying. I have another branch where I started that work, but will submit it separately.