Skip to content

Prevent mergify from updating labels while CI is still running #7470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Mergify adds ready-for-review before the CI jobs have started / are running.

I've stripped out all the negation conditions to avoid the rules getting fired too easily.

@jimmygchen jimmygchen added ready-for-review The code is ready for review skip-ci Don't run the `test-suite` labels May 16, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

mergify bot commented May 16, 2025

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels May 16, 2025
@jimmygchen jimmygchen merged commit e0ee148 into sigp:stable May 16, 2025
28 of 30 checks passed
owanikin pushed a commit to owanikin/lighthouse that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Don't run the `test-suite` waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants