Update mergify rule to avoid unnecessarily firing some rules #7494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - to reduce noise and avoid updating stale PRs.
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
the
waiting-on-author
jimmygchen
added
ready-for-review
mergify
bot
added
waiting-on-author
macladson
approved these changes
May 21, 2025
owanikin
pushed a commit
to owanikin/lighthouse
that referenced
this pull request
Jun 23, 2025
… - to reduce noise and avoid updating stale PRs. (sigp#7494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that mergify spams PRs with comments even before they're marked as reviewed. It also comments on PRs that are stale and not in the
ready-for-reviewstate.This PR updates those mergify rules to not evaluate PRs that are not ready for review, so that it reduces noise and avoid updating stale PRs.