Make block available when we have 50% of columns on supernodes #7598
+118
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When we, as a supernode, have 50% of columns, we are able to reconstruct the remaining 50%. If we have verified the columns, this operation (theoretically) cannot fail.
So, we can treat the block as available as it is only a matter of time until we have all columns. This PR experimentally imports the block into fork choice when we have 50% of columns.
Additionally, we add some logic to delay responding to get column by root if we do not have all columns in DA checker yet. But that one might worsen network conditions compared to just returning partial or no columns.
This hasn't been thoroughly tested yet