Skip to content

feat(beacon_node/beacon_chain): Removed DataColumnInfo #7624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

feat(beacon_node/beacon_chain): Removed DataColumnInfo #7624

wants to merge 1 commit into from
+4 −160

Conversation

PoulavBhowmick03
Copy link
Contributor

Issue Addressed

Potentially Fixes #6572

Proposed Changes

  • Removed DataColumnInfo from beacon_node/store/src/metadata.rs and it's metadata
  • Removed data column initialization in beacon chain builder
  • Simplified RPC methods to use data_availability_boundary_slot directly
  • Removed database operations for data column info storage/retrieval
  • Cleaned up unused imports

@PoulavBhowmick03 PoulavBhowmick03 requested a review from jxs as a code owner June 21, 2025 17:08
@eserilev eserilev added code-quality das Data Availability Sampling optimization Something to make Lighthouse run more efficiently. database ready-for-review The code is ready for review and removed code-quality labels Jun 22, 2025
michaelsproul
michaelsproul requested changes Jun 23, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this change will also require a DB schema change in order to clean up the old data (to delete it). We'll also need a downgrade which recreates it. Seeing as the value is informational, the downgrade could just set the oldest data column slot to the split slot.

We are planning out schema upgrades and allocating versions in this issue:

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jun 23, 2025
@michaelsproul michaelsproul mentioned this pull request Jun 23, 2025
Open
@jimmygchen jimmygchen mentioned this pull request Jun 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul requested changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
das Data Availability Sampling database optimization Something to make Lighthouse run more efficiently. waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PoulavBhowmick03 @michaelsproul @eserilev