Add support for syft json type to cosign #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sambhav Kothari <[email protected]>
Member
Contributor
Author
|
Not sure why the cosigned tests are failing but it looks unrelated to the PR |
Member
yes, seems something is broken, this is not related to your PR 🤝 |
Member
|
Looks great! Let's see if we can chase down the ci failure. |
Member
|
Looks like the distroless image is not actually signed: GoogleContainerTools/distroless#905 |
dlorenc
reviewed
Dec 5, 2021
Signed-off-by: Sambhav Kothari <[email protected]>
dlorenc
approved these changes
Dec 6, 2021
sambhav
added a commit
to sambhav/cosign
that referenced
this pull request
Jan 6, 2022
This documents the support for syft json added in sigstore#1137 Signed-off-by: Sambhav Kothari <[email protected]>
dlorenc
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Update SBOM spec to indicate compat for syft This documents the support for syft json added in #1137 Signed-off-by: Sambhav Kothari <[email protected]> * Reword SBOM wording to indicate that the formats are cosign specific As noted by @VinodAnandan - the previous message may have caused confusion about NTIA recorgnized formats v/s formats cosign uses. Updating the wording to explicitly call out cosign supported formats. Signed-off-by: Sambhav Kothari <[email protected]>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Update SBOM spec to indicate compat for syft This documents the support for syft json added in sigstore#1137 Signed-off-by: Sambhav Kothari <[email protected]> * Reword SBOM wording to indicate that the formats are cosign specific As noted by @VinodAnandan - the previous message may have caused confusion about NTIA recorgnized formats v/s formats cosign uses. Updating the wording to explicitly call out cosign supported formats. Signed-off-by: Sambhav Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sambhav Kothari [email protected]
Summary
Add support for syft format in cosign attach sbom
Ticket Link
Fixes #1136
Release Note