Move bundle definition out of oci and into bundle package
#1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a little more sense since the bundle isn't really tied to oci, and will make it easier to implement the on-disk bundle. This allows removes a little code duplication. Signed-off-by: Priya Wadhwa <[email protected]>
dlorenc
approved these changes
Jan 11, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
This makes a little more sense since the bundle isn't really tied to oci, and will make it easier to implement the on-disk bundle. This allows removes a little code duplication. Signed-off-by: Priya Wadhwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a little more sense since the bundle isn't really tied to oci, and will make it easier to implement the on-disk bundle for #1193 by creating the
EntryToBundlefunc which was previously duplicated across packages.Signed-off-by: Priya Wadhwa [email protected]