Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Jun 9, 2023

Closes: #3039

Summary

The documentation was incorrectly pointing to github as provider, while it needs to be github-actions.

Release Note

NONE

Documentation

This is a fix for documentation

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #3040 (025423d) into main (4293942) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 025423d differs from pull request most recent head d6e51d6. Consider uploading reports for the commit d6e51d6 to get more accurate results

@@            Coverage Diff             @@
##             main    #3040      +/-   ##
==========================================
- Coverage   31.08%   31.07%   -0.01%     
==========================================
  Files         155      155              
  Lines        9739     9732       -7     
==========================================
- Hits         3027     3024       -3     
+ Misses       6250     6247       -3     
+ Partials      462      461       -1     

see 3 files with indirect coverage changes

@yrobla yrobla force-pushed the issue-3039 branch 2 times, most recently from 75f1dd8 to 025423d Compare June 9, 2023 07:01
@cpanato
Copy link
Member

cpanato commented Jun 9, 2023

There is no change here. Can you double-check your commits?

thanks

hectorj2f
hectorj2f previously approved these changes Jun 9, 2023
@hectorj2f hectorj2f dismissed their stale review June 9, 2023 08:07

No changes here

@haydentherapper
Copy link
Contributor

You’ll need to update the description of the flag where it’s defined, then run make docgen

The documentation was incorrectly pointing to github
as provider, while it needs to be github-actions.

Closes: sigstore#3039
Signed-off-by: Yolanda Robla <[email protected]>
@haydentherapper haydentherapper enabled auto-merge (squash) June 12, 2023 14:49
@yrobla
Copy link
Contributor Author

yrobla commented Jun 12, 2023

You’ll need to update the description of the flag where it’s defined, then run make docgen

apologies, i didn't get that the documentation was generated directly from the cli commands.

@haydentherapper haydentherapper merged commit 288c458 into sigstore:main Jun 12, 2023
@github-actions github-actions bot added this to the v1.14.0 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oidc-provider documentation is showing incorrect option for github

4 participants