added Attachment() method to oci.SignedEntity
#857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Oct 6, 2021
Member
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Generally this looks like the right direction, I'd take it one step further in this PR 😉
dekkagaijin
force-pushed
the
attached
branch
2 times, most recently
from
f83cfc9 to
2eb3f63
Compare
Signed-off-by: Jake Sanders <[email protected]>
mattmoor
approved these changes
Oct 17, 2021
mattmoor
added a commit
to mattmoor/cosign
that referenced
this pull request
Oct 17, 2021
This was missing from sigstore#857, which WAS green, so HEAD is broken until this lands. Signed-off-by: Matt Moore <[email protected]>
n3wscott
pushed a commit
that referenced
this pull request
Oct 17, 2021
This was missing from #857, which WAS green, so HEAD is broken until this lands. Signed-off-by: Matt Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for users to easily fetch named File "attachments" associated with an image.
Ticket Link
#844
Release Note