Add the OIDC options to AttestOptions.
#918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
commented
Oct 19, 2021
| Rekor RekorOptions | ||
| Fulcio FulcioOptions | ||
| OIDC OIDCOptions | ||
| SecurityKey SecurityKeyOptions |
Member
Author
There was a problem hiding this comment.
I reordered these trying to compare with Attest...
Member
Author
|
cc @vaikas |
Without this, I get the following (back to 1.0):
```
Error: signing gcr.io/mattmoor-credit/sbom@sha256:faef0ba9f497e26509d9f72f9ece7016b0e36edcb34ea3d3afe04f4bb2b01c5d: getting signer: getting key from Fulcio: retrieving cert: Get "/.well-known/openid-configuration": unsupported protocol scheme ""
main.go:48: error during command execution: signing gcr.io/mattmoor-credit/sbom@sha256:faef0ba9f497e26509d9f72f9ece7016b0e36edcb34ea3d3afe04f4bb2b01c5d: getting signer: getting key from Fulcio: retrieving cert: Get "/.well-known/openid-configuration": unsupported protocol scheme ""
exit status 1
```
With this change, it gets further, but there are still issues:
```
Error: signing gcr.io/mattmoor-credit/sbom@sha256:faef0ba9f497e26509d9f72f9ece7016b0e36edcb34ea3d3afe04f4bb2b01c5d: [POST /api/v1/log/entries][400] createLogEntryBadRequest &{Code:400 Message:Error processing entry: unsupported public key type}
main.go:48: error during command execution: signing gcr.io/mattmoor-credit/sbom@sha256:faef0ba9f497e26509d9f72f9ece7016b0e36edcb34ea3d3afe04f4bb2b01c5d: [POST /api/v1/log/entries][400] createLogEntryBadRequest &{Code:400 Message:Error processing entry: unsupported public key type}
exit status 1
```
Signed-off-by: Matt Moore <[email protected]>
dlorenc
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, I get the following (back to 1.0):
With this change, it gets further, but there are still issues:
Signed-off-by: Matt Moore [email protected]
Release Note