Add keyless signing w/ storage in rekor to FUN.md #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squee1945
reviewed
Oct 19, 2021
squee1945
reviewed
Oct 19, 2021
| 2djlcXFUJb1xFwO5 | ||
| -----END CERTIFICATE----- | ||
| tlog entry created with index: 782549 |
There was a problem hiding this comment.
Related feedback: it seems like Cosign should emit an immutable https:// link to rekor for the tlog entry here.
squee1945
reviewed
Oct 19, 2021
| Now find it from the log: | ||
|
|
||
| ``` | ||
| $ uuid=$(rekor-cli search --artifact <(git rev-parse HEAD) | tail -n 1) |
There was a problem hiding this comment.
I assume tail -n 1 retrieves the most recent signature for a given hash. I suppose a real world example would already know the git hash that it wanted to check...
Contributor
Author
There was a problem hiding this comment.
yah we're just checking out the most recent signature here. realistically you might get a list & have to go through each entry to see if a trusted identity signed off on the commit.
Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
keyless-sign-git-commit
branch
from
ab20430 to
3abd1e0
Compare
dlorenc
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I filled in the last section of this doc! Let me know if I didn't do this the intended way 😅