Fix cosign attach sbom with COSIGN_REPOSITORY.
#970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the env var is ignored by this command because it directly uses GGCR registry options instead of the `ociremote` options (which include the default override). This fixes things by passing the `ociremote` options from `regOpts` to `SBOMTag`. Signed-off-by: Matt Moore <[email protected]>
Contributor
|
Thanks! |
vaikas
approved these changes
Oct 29, 2021
dlorenc
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the env var is ignored by this command because it directly uses GGCR registry options instead of the
ociremoteoptions (which include the default override).This fixes things by passing the
ociremoteoptions fromregOptstoSBOMTag.Signed-off-by: Matt Moore [email protected]
Thanks to @vaikas for finding this.
Ticket Link
Release Note