Skip to content

Conversation

@dirien
Copy link
Contributor

@dirien dirien commented Nov 3, 2021

Signed-off-by: Engin Diri [email protected]

Summary

Hello cosign community and @cpanato,

I added GoFish support via goreleasers (@caarlos0). The only things we need before merging this PR:

A github repo called: fish-food similar to https://github.com/goreleaser/fish-food and and ensure access to it during the release process.

owner: sigstore
name: fish-food

Ticket Link

Fixes #855

Release Note

NONE


@dirien
Copy link
Contributor Author

dirien commented Nov 3, 2021

Hi @caarlos0 and @cpanato, here the PR continues. I screwed the original one. :/

@dlorenc
Copy link
Member

dlorenc commented Nov 7, 2021

I think we have the repo setup here: https://github.com/sigstore/fish-food

Is there anything we have to do to get permissions setup correctly?

@cpanato
Copy link
Member

cpanato commented Nov 7, 2021

i will test this this week in my fork to validate, bear with me

@cpanato
Copy link
Member

cpanato commented Nov 18, 2021

so sorry @dirien for the huge delay on this

I'm finishing some things and will try this out soon, please bear with me 🐻

@cpanato
Copy link
Member

cpanato commented Nov 18, 2021

did a test and the outcome can be found here: https://github.com/cpanato/fish-food-test

looks like we are publishing all, is that we want? or only cosign and sget?

@dirien dirien force-pushed the gofish branch 2 times, most recently from 0e184bf to e9fd478 Compare November 19, 2021 17:57
@dirien
Copy link
Contributor Author

dirien commented Nov 19, 2021

rebase done, and added the newline

Signed-off-by: Engin Diri <[email protected]>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this 🎉 and sorry for taking too long :(

@dlorenc we need to make sure the bot is added in the fish-food repo as well

@dlorenc
Copy link
Member

dlorenc commented Nov 23, 2021

Should I merge? The bot looks added:

image

@cpanato
Copy link
Member

cpanato commented Nov 23, 2021

@dlorenc we are good in this side

@dlorenc dlorenc merged commit 040ed3d into sigstore:main Nov 23, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Nov 23, 2021
@dirien dirien deleted the gofish branch November 23, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GoFish support

3 participants