Skip to content

Conversation

@miyunari
Copy link
Member

@miyunari miyunari commented Sep 22, 2024

Closes #1811

Summary

The PR #1720 has changed the default config path from /etc/fulcio-config/config.json to /etc/fulcio-config/config.yaml. This caused problems with non-explicitly configured environments.

Release Note

Check and fallback to default JSON config if the default YAML configuration file did not exist.

Documentation

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.19%. Comparing base (cf238ac) to head (53fc3e7).
Report is 212 commits behind head on main.

Files with missing lines Patch % Lines
cmd/app/serve.go 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1810      +/-   ##
==========================================
- Coverage   57.93%   50.19%   -7.75%     
==========================================
  Files          50       70      +20     
  Lines        3119     4202    +1083     
==========================================
+ Hits         1807     2109     +302     
- Misses       1154     1858     +704     
- Partials      158      235      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miyunari miyunari marked this pull request as ready for review September 23, 2024 16:14
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haydentherapper
Copy link
Contributor

Will need to rebase once #1814 merges.

@haydentherapper
Copy link
Contributor

Needs a rebase.

@miyunari miyunari force-pushed the change_default_config branch from d218862 to 53fc3e7 Compare October 4, 2024 11:08
@miyunari
Copy link
Member Author

miyunari commented Oct 4, 2024

Needs a rebase.

Sry @haydentherapper, just saw this and rebased it now 👍

@cpanato cpanato merged commit a2cba3e into sigstore:main Oct 4, 2024
@miyunari miyunari deleted the change_default_config branch October 7, 2024 12:04
javanlacerda pushed a commit to javanlacerda/fulcio that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

config default path changed

3 participants