Skip to content

Conversation

@adityasaky
Copy link
Member

Summary

This PR adds the IDP type and subject domain (for URI and Username IDPs) to the Fulcio configuration API response.

Release Note

Added IDP type and subject domain to Fulcio configuration API response

Documentation

None

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 50.33%. Comparing base (cf238ac) to head (6d5c0d6).
Report is 210 commits behind head on main.

Files with missing lines Patch % Lines
pkg/generated/protobuf/fulcio.pb.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
- Coverage   57.93%   50.33%   -7.61%     
==========================================
  Files          50       70      +20     
  Lines        3119     4198    +1079     
==========================================
+ Hits         1807     2113     +306     
- Misses       1154     1852     +698     
- Partials      158      233      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haydentherapper haydentherapper merged commit df65c59 into sigstore:main Sep 30, 2024
@adityasaky adityasaky deleted the expose-idp-type branch September 30, 2024 16:40
javanlacerda pushed a commit to javanlacerda/fulcio that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants