fix: vault for enterprise expects only the key name #2117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianhundere
force-pushed
the
fix/fixes-vault-key-name-conventions
branch
2 times, most recently
from
ae6abdd to
43394e6
Compare
haydentherapper
previously approved these changes
Jul 30, 2025
ianhundere
force-pushed
the
fix/fixes-vault-key-name-conventions
branch
from
a742508 to
f160e9b
Compare
Contributor
Author
|
@haydentherapper i saw the build tests failed, i'm assuming that's okay tho. 🤔 |
ianhundere
force-pushed
the
fix/fixes-vault-key-name-conventions
branch
from
f160e9b to
b582a92
Compare
… the full path. Signed-off-by: ianhundere <[email protected]>
Signed-off-by: ianhundere <[email protected]>
ianhundere
force-pushed
the
fix/fixes-vault-key-name-conventions
branch
from
681a873 to
12f01b4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2117 +/- ##
===========================================
- Coverage 57.93% 43.59% -14.34%
===========================================
Files 50 71 +21
Lines 3119 5656 +2537
===========================================
+ Hits 1807 2466 +659
- Misses 1154 2965 +1811
- Partials 158 225 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
haydentherapper
left a comment
haydentherapper
left a comment
There was a problem hiding this comment.
Can you revert the protobuf file changes? I’ll guess that your local environment has a different version of the protobuf compiler installed.
ianhundere
force-pushed
the
fix/fixes-vault-key-name-conventions
branch
from
12f01b4 to
ce48af6
Compare
Signed-off-by: ianhundere <[email protected]>
ianhundere
force-pushed
the
fix/fixes-vault-key-name-conventions
branch
from
ce48af6 to
5bc2bfc
Compare
Contributor
Author
done / done, thanks for the quick approval. |
ianhundere
changed the title
haydentherapper
approved these changes
Jul 31, 2025
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2118
Summary
currently, cert-maker will fail when using vault enterprise as per:
error initializing root KMS: failed to initialize HashiVault KMS: kms specification should be in the format hashivault://<key>Release Note
Documentation
will update docs (e.g. include
VAULT_NAMESPACEenv var etc)