Upgrade to Svelte 5 #1066
Upgrade to Svelte 5 #1066
Conversation
FyreByrd
force-pushed
the
upgrade/svelte-5
branch
from
9db5468 to
a8e64e5
Compare
FyreByrd
force-pushed
the
upgrade/svelte-5
branch
from
4bd968d to
c8552e8
Compare
I have updated the branch to just have the Svelte 5 changes, with a few exceptions:
|
FyreByrd
force-pushed
the
upgrade/svelte-5
branch
from
2b802a5 to
0c7b747
Compare
FyreByrd
force-pushed
the
upgrade/svelte-5
branch
from
0c7b747 to
19ee295
Compare
|
As of right now, I have two possible fixes for the flatpickr issue. svelte-flatpickr-plusbranch: https://github.com/sillsdev/appbuilder-portal/tree/fix/flatpickr Has some peer dependency warnings because the library also includes the dependencies for the documentation website. Pikadaybranch: https://github.com/sillsdev/appbuilder-portal/tree/fix/use-pikaday Isn't the prettiest, but I was able to finagle it to work for our use case for now. Part of the reason for this one is that the next major version of DaisyUI has styling for this library. |
FyreByrd
force-pushed
the
upgrade/svelte-5
branch
from
19ee295 to
ca547e7
Compare
This was done to ensure that all our dependencies work with Svelte 5. svelte-flatpickr has a broken peer dependency, but appears to otherwise work. Note: TailwindCSS and DaisyUI have new major versions in about a month.
BullMQAdapter is in fact the correct adapter since we are using bullmq, not bull This was to solve an issue that may have been introduced by upgrading all the dependencies.
This bug cause the issue: npm/cli#4828
This was not an issue before Svelte 5. My assumption is that it has something to do with how Svelte 5 uses Proxies for deep reactivity.
FyreByrd
force-pushed
the
upgrade/svelte-5
branch
from
461b56f to
c132779
Compare
|
Fixed merge conflicts |
| icon, | ||
| width, | ||
| tooltip = '', | ||
| class: classes = '' |
There was a problem hiding this comment.
I kept the original prop name from before the Svelte 5 upgrade. In both Svelte 4 and Svelte 5 it is an error to have a prop directly named class, probably because it is a reserved keyword in JS/TS
* Trivial changes from migration * Fix imports * Handle migration-tasks * Remove all svelte/legacy * Migrate some components/pages that failed earlier * Upgrade some packages This was done to ensure that all our dependencies work with Svelte 5. svelte-flatpickr has a broken peer dependency, but appears to otherwise work. Note: TailwindCSS and DaisyUI have new major versions in about a month. * Use BullMQAdapter BullMQAdapter is in fact the correct adapter since we are using bullmq, not bull This was to solve an issue that may have been introduced by upgrading all the dependencies. * Use snippets for Pagination component * Replace writable with $state * Remove erroneous $state() * Add peer-dependency override for svelte-flatpickr * Fix package-lock for platform-specific deps This bug cause the issue: npm/cli#4828 * Fix infinite loop bug in SortTable This was not an issue before Svelte 5. My assumption is that it has something to do with how Svelte 5 uses Proxies for deep reactivity. * Fix styling on LanguageCodeTypeahead * Fix pagination for Svelte 5 * Fix infinite loop bug for user invite * Change user invite button style
Upgraded project to use latest version of Svelte.
Upgraded a few other libraries