Adding items to custom lists doesn't do the right thing

[rmunn]

In the project configuration UI, there's an Option Lists tab where you can add new entries to a list:

This appears to work, but then when you go into the main editor interface and try to select an item from that custom list, it shows as "Unknown" instead of the correct value:

That should have shown up as "Three", the item I just added to the custom list.

Also, Send/Receive seems to not send that added item, which might be its own issue. I don't have enough of a reproduction nailed down to create an issue about that one, but I'll create a new issue when I do.

[rmunn]

A bit of background about custom lists, and custom fields that reference custom lists. In Language Forge (and in FieldWorks), list items have a key that never changes, and a name and abbreviation that can have different values in each language. For example, for the Grammatical Categories list, the list entry with the name "pronoun" in English would have the name "pronom" in French. And their abbreviation would be different, too: in English you'd expect "pro" as the abbeviation for pronoun, but a French speaker would expect either "pn" or "pron" as the abbreviation.

Therefore, when creating a new list item, the Language Forge UI needs to allow people to specify both the name and the abbreviation. And hopefully it would create the key from the abbreviation, first searching through the list of existing keys of that list to verify that it wouldn't be creating a duplicate. Right now the abbreviation is left undefined, and that search for duplicates doesn't happen:

  pickAddItem(): void {
    if (this.newValue) {
      const key = PickListEditorController.keyFromValue(this.newValue);
      this.items.push({ key, value: this.newValue });
      this.isDeletable[key] = true;
      this.newValue = undefined;
    }
  }

  static keyFromValue(value: string): string {
    return value.replace(/ /gi, '_');
  }

This is, I believe, part of why Send/Receive of new items in custom lists isn't working right: because Language Forge allows creation of duplicate keys, and doesn't set abbreviations at all.

Now, there may also be bugs in LfMerge related to custom lists; that's an area of the code that is very difficult to test in any kind of automated way, so I'm sure there are bugs lurking in there somewhere that I haven't found yet. But until we fix how Language Forge handles them, I don't think I can make any further progress in fixing the LfMerge Send/Receive process regarding custom lists.