SF-3418 Lynx fix text is being inserted at wrong index

[ddaspit]

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.09%. Comparing base (d58f79b) to head (0475971).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...r-objects/lynx-insight-editor-objects.component.ts	0.00%	10 Missing ⚠️
...ion-prompt/lynx-insight-action-prompt.component.ts	0.00%	5 Missing ⚠️
...hts/quill-services/quill-insight-render.service.ts	0.00%	2 Missing ⚠️
...e/ClientApp/src/app/shared/text/text-view-model.ts	50.00%	1 Missing ⚠️
...-insight-overlay/lynx-insight-overlay.component.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
+ Coverage   81.99%   82.09%   +0.09%     
==========================================
  Files         605      605              
  Lines       35112    35121       +9     
  Branches     5716     5695      -21     
==========================================
+ Hits        28790    28832      +42     
+ Misses       5490     5455      -35     
- Partials      832      834       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Nateowami]

@ddaspit Is there an issue this is supposed to solve?

[ddaspit]

This solves an issue in Lynx.

[Nateowami]

@ddaspit could you try to come up with a title that's more descriptive (as defined by CONTRIBUTING.md)?

Something like:

SF-1234 Fix Lynx inserting instead of replacing quote

(Not sure whether there's a Jira issue for this. If not, there should be one so it can go through the testing process before merging)

[RaymondLuong3]

The code changes look good, but please create a jira issue with acceptance tests so that I can confirm if this change solves the issue it is supposed to solve.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @siltomato)

[siltomato]

Nice! This looks good to me and solves the problem of note embeds causing lynx fix offsets to be wrong.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

[ddaspit]

@siltomato Do you know if there is a Jira issue for this?

[siltomato]

I created one: https://jira.sil.org/browse/SF-3418

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

[siltomato]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

[ddaspit]

I added a unit test to cover the issue and updated the title.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

[siltomato]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

[siltomato]

I added a fix for the incorrect action prompt location (also due to note embeds).

Reviewable status: 6 of 14 files reviewed, all discussions resolved (waiting on @RaymondLuong3)