Do not store Go pointers in C structs #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really should test my own code more often :|. Thanks for your fix, merged! |
|
Regarding the other error ("fatal error: sweep increased allocation count"): I will look into that in more detail on the weekend. Perhaps I can find something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Go 1.7, the rules around passing pointers from/to C are even stricter. See e.g. this bug.
When running Go 1.7, this would work before the patch:
But more strict checking fails:
This is fixed with this pull request.
There appear to be more problems in my application seemingly related to golibrsync (
fatal error: sweep increased allocation count), but I haven't tracked them down yet.