MNT Don't fail test for unrelated line number change #11916
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symfony/yaml changed which line it thinks the error is on - arguably the change is wrong, but arguably the line number was already wrong anyway (the actual error is on line 4, but we used to expect line 5, and it changed to reporting line 6). We shouldn't care what line symfony is reporting about - what really matters is that the error we expect is the error that is thrown.
Closed
emteknetnz
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/yaml changed which line it thinks the error is on - arguably the change is wrong, but arguably the line number was already wrong anyway (the actual error is on line 4, but we used to expect line 5, and it changed to reporting line 6).
We shouldn't care what line symfony is reporting about - what really matters is that the error we expect is the error that is thrown.
Important
Intentionally targetting
6.0since this doesn't affect projects but does make CI green.6.0is still supported for security fixes so we should ideally keep CI green on that branch.Doesn't affect 5.4 because this only started failing with
symfony/yaml 7.4.0which can't be installed with framework 5.4Issue