Skip to content

Code improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sindresorhus opened this issue Jun 30, 2017 · 1 comment
Closed

Code improvements #2

sindresorhus opened this issue Jun 30, 2017 · 1 comment

Comments

@sindresorhus
Copy link
Contributor

child_process.execFile() should be used over .exec() as it's both faster and safer. I think we should also use either pify or execa to make the code more readable.
@silverwind
Copy link
Owner

Yes, using execa is planned. I just found .exec easier to use while testing because of the ability to give the full command as a string.

silverwind pushed a commit that referenced this issue Feb 25, 2019
@ThePrez @silverwind
WIP: initial pure js impl for IBM i AIX variant (#11)
57a75d3 
* initial pure js impl for IBM i AIX variant

* Fix style errors

* minor bugfix with unassigned const

* fix style errors #2

* remove silly plus sign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silverwind @sindresorhus