Implement sync() methods #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
silverwind
reviewed
Sep 28, 2017
android.js
Outdated
|
|
||
| return result; | ||
| const get = family => { |
There was a problem hiding this comment.
care to rename these to async?
There was a problem hiding this comment.
no problem at all.
silverwind
reviewed
Sep 28, 2017
index.js
Outdated
| @@ -11,9 +11,16 @@ if ([ | |||
| "sunos", | |||
| "win32" | |||
| ].indexOf(platform) !== -1) { | |||
| module.exports.v4 = () => require(`./${platform}`).v4(); | |||
| module.exports.v6 = () => require(`./${platform}`).v6(); | |||
| const fams = require(`./${platform}`); | |||
There was a problem hiding this comment.
very minor, but i'd prefer families here.
|
give me about 30 minutes to switch back to this and i'll make those updates for you |
silverwind
reviewed
Sep 28, 2017
win32.js
Outdated
| return result; | ||
| }; | ||
|
|
||
| const wmic = family => { |
There was a problem hiding this comment.
same here, just rename to async.
|
LGTM once those things are renamed. |
|
@silverwind just remembered - |
|
Lowercase |
|
@silverwind should be all set. happy to make additional changes if you spot anything |
|
Thanks, I'll update docs and then push a release. |
silverwind
pushed a commit
that referenced
this pull request
Mar 27, 2018
* MAKEFILE should use local eslint * implement sync() methods * get -> promise rename * fams -> families rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This facilitates the re-addition of sync methods to
internal-ip, citing this issue there. All platforms for both families have been assigned sync methods usingexeca.sync. Tests were updated to also consider sync methods and run locally on OSX and Ubuntu with success.This change is necessary in order for
internal-ipand other consumers ofdefault-gatewayto implement synchronous methods. I followed the patterns established in the source but let me know if you'd like to see any semantic changes.