Skip to content

Parse HDF5 string padding metadata#1659

Merged
axelboc merged 1 commit into
mainfrom
h5t_str
Jun 5, 2024
Merged

Parse HDF5 string padding metadata#1659
axelboc merged 1 commit into
mainfrom
h5t_str

Conversation

@axelboc

@axelboc axelboc commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Fix #1621

As discussed, it remains visible only under the Inspect accordion:

image

@axelboc axelboc force-pushed the h5t_str branch 3 times, most recently from 7786645 to 67f9753 Compare June 4, 2024 15:00
Comment thread tsconfig.json
"compilerOptions": {
"module": "preserve",
"module": "esnext",
"moduleResolution": "bundler",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, ESLint started complaining about preserve after I upgraded h5wasm... 🤷 Reverting for now.

@loichuder loichuder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@axelboc axelboc merged commit 86848a7 into main Jun 5, 2024
@axelboc axelboc deleted the h5t_str branch June 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String padding

2 participants