Document and test dimension mapping utilities#1829
Merged
Conversation
axelboc
commented
Jun 23, 2025
| import { type Axis, type DimensionMapping } from '@h5web/shared/vis-models'; | ||
|
|
||
| import styles from './DimensionMapper.module.css'; | ||
| import { type DimensionMapping } from './models'; |
Contributor
Author
There was a problem hiding this comment.
I've moved the DimensionMapping type to the shared package. It seemed more logical and it was lonely in a file all by itself... 😁
|
|
||
| interface Props extends Omit<HTMLAttributes<HTMLDivElement>, 'onChange'> { | ||
| dims: number[]; | ||
| dimHints?: AxisMapping<string>; |
Contributor
Author
There was a problem hiding this comment.
AxisMapping was created as a NeXus concept (it's in nexus-models.ts in the shared package). Now that the DimensionMapper is exposed, I prefer to remove this subtle coupling with NeXus. It makes the type of the dimHints prop more explicit at the same time.
loichuder
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR about moving the dimension mapper and related utilities to the lib.
useSlicedDimsAndMapping:getSlicedDimsAndMapping.initDimMapping,getSliceSelection,getSlicedDimsAndMapping(anduseSlicedDimsAndMapping)getSliceSelectionandgetSlicedDimsAndMapping(I already wrote tests forinitDimMappingin a previous PR)