Support right mouse button and preventing default context menu#1830
Merged
Conversation
8f878c1 to
7b84def
Compare
loichuder
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1813
Pan,SelectToZoom, etc. can now be configured with the right mouse button.PreventDefaultContextMenuprevents the browser from showing its native context menu on right-click. Propwhencontrols this behaviour:'as-needed'(the default), the context menu is prevented only when an interaction based on the right mouse button is registered and enabled;'always', the context menu is always prevented regardless of registered interactions;'never', the context menu is never prevented regardless of registered interactions.PreventDefaultContextMenuto be able to access registered interactions, I expose agetInteractionsfunction through the existingInteractionsContext. It returns all registered interactions by default, but it can also filter them when given a specific mouse button/modifier key.PreventDefaultContextMenutoDefaultInteractionsso it works out of the box in all high-level visualization components (LineVis, etc.).InteractionsContext,getInteractionsandPreventDefaultContextMenu, and I add aPanstory with the right mouse button.Screencast.from.2025-06-25.14-49-38.webm