Increase test coverage of explorer and search#1934
Merged
Conversation
axelboc
commented
Dec 22, 2025
| } | ||
| if (isExpanded) { | ||
| focusNext(e); | ||
| focusNext(evt, true); |
Contributor
Author
There was a problem hiding this comment.
The fix starts here; I pass true to focusNext to restrict the search of the next button to focus to the children only.
Comment on lines
-41
to
-43
| if (!path) { | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
If the data-path attribute is not present on an explorer button, it's a bug, so replace with an assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search wasn't tested at all, and in the explorer, we weren't testing the keyboard navigation.
Both the
searchandexplorerfolders now have 100% test coverage, which adds two percentage points overall. We're now on 62.66%.While testing the keyboard navigation in the explorer, I noticed a subtle bug: when pressing the right arrow key on an already expanded empty group, the focus would move to the sibling of the group instead of remaining on the group. Below is a screen recording of the bug where I press the right arrow key five times in a row:
Screencast.from.2025-12-22.16-08-08.webm
Now the focus remains on the group — here I press the right arrow key 10 times:
Screencast.from.2025-12-22.16-10-22.webm