Fix ordering of compound fields with number-like names#1970
Merged
Conversation
axelboc
commented
Mar 4, 2026
Comment on lines
+115
to
+117
| return compoundOrCplxType( | ||
| hsdsType.fields.map((v) => [v.name, convertHsdsType(v.type)]), | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Now calling compoundOrCplxType like in the other providers.
The subtle but negligible change from before is that if the r and i fields are present but not numeric, compoundOrCplxType doesn't throw an error — it just falls back to creating a compound type.
| }, | ||
| "members": { | ||
| "0": { | ||
| "members": [ |
Contributor
Author
There was a problem hiding this comment.
This shows the new array format returned by h5grove.
| "class": "Boolean", | ||
| }, | ||
| "1": { | ||
| "fields": Map { |
Contributor
Author
There was a problem hiding this comment.
This shows the new internal format for compound fields.
Comment on lines
-1625
to
-1631
| "bigint": { | ||
| "class": 0, | ||
| "dtype": "<i8", | ||
| "order": 0, | ||
| "sign": 1, | ||
| "size": 8, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Another fix here, but I think it was an issue with Vitest's snapshot serialization because the order was correct in the UI:
axelboc
force-pushed
the
compound-fields-array
branch
from
f51b999 to
34a7461
Compare
loichuder
approved these changes
Mar 11, 2026
loichuder
left a comment
loichuder
left a comment
Member
There was a problem hiding this comment.
Sorry for the late review 😉
All good!
axelboc
force-pushed
the
compound-fields-array
branch
from
3ecfb81 to
6b883b2
Compare
axelboc
force-pushed
the
compound-fields-array
branch
from
f3e83c5 to
a690d89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1765
The metadata of compound fields is now stored in a
Mapinstead of a plain object in order to maintain proper ordering of fields with number-like names ("0", "1", etc.)This also required changing the
metaendpoint of h5grove to return compound fields metadata as an array instead of an object, just like HSDS and h5wasm.h5grove@4.0.0(for now4.0.0rc1)