Angle brackets (<, >) not accepted in stdout for format 1

[agander]

The following:

echo "<a>"
>>>
<a>
>>>2
>>>= 0

generates this error:

tests/format1/html.test
:parse error in tests/format1/html.test: [Failed]
tests/format1/html.test" (line 2, column 1):
unexpected 'e'
expecting comments, lf new-line or end of input

[agander]

Does this ptrace output reveal anything?

shelltest 1.9
args: Args
  { list = False
  , include = []
  , exclude = [ "/_" ]
  , all_ = False
  , color = False
  , diff = False
  , precise = False
  , hide_successes = True
  , xmlout = ""
  , defmacro = []
  , execdir = False
  , extension = ".test"
  , with = ""
  , timeout = 0
  , threads = 16
  , debug = True
  , debug_parse = False
  , testpaths = [ "tests/format1/html.test" ]
  }
processing 1 test files: tests/format1/html.test
parseShellTestFile 0: D:parseFromFileWithPreprocessor 0: : Right "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0\n\n"
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"    shelltestfile 0
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"     format2testgroup 0: False
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"     format2testgroup 1
at line  7 col  1: ""                                         format2testgroup i: Just "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0\n\n"
at line  7 col  1: ""                                          format2test 0
at line  7 col  1: ""                                          format2test 1
at line  7 col  1: ""                                          format2test ln: 7
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"     format3testgroup 0: False
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"     format3testgroup 1
at line  3 col  1: "<a>\n>>>2\n>>>= 0\n\n"                    format3testgroup i: Just "echo \"<a>\"\n>>>\n"
at line  3 col  1: "<a>\n>>>2\n>>>= 0\n\n"                     format3test 0
at line  3 col  1: "<a>\n>>>2\n>>>= 0\n\n"                     format3test 1
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"     format1test 0
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"     format1test 1
at line  2 col  1: ">>>\n<a>\n>>>2\n>>>= 0\n\n"               format1test c: ReplaceableCommand "echo \"<a>\""
at line  2 col  1: ">>>\n<a>\n>>>2\n>>>= 0\n\n"               format1test i: Nothing
at line  2 col  1: ">>>\n<a>\n>>>2\n>>>= 0\n\n"               format1test o: Nothing
at line  2 col  1: ">>>\n<a>\n>>>2\n>>>= 0\n\n"               format1test e: Nothing
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"    shelltestfile ts : []
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"    shelltestfile 3
at line  1 col  1: "echo \"<a>\"\n>>>\n<a>\n>>>2\n>>>= 0"    shelltestfile 4
parseShellTestFile 1: : Left "tests/format1/html.test" (line 7, column 1):
unexpected end of input
expecting comments, lf new-line or command line
failed to parse any tests in tests/format1/html.test
running tests:
:parse error in tests/format1/html.test: [Failed]
"tests/format1/html.test" (line 7, column 1):
unexpected end of input
expecting comments, lf new-line or command line

         Test Cases  Total      
 Passed  0           0          
 Failed  1           1          
 Total   1           1          
make: *** [Makefile:84: testformat1-html] Error 1
Received ExitFailure 2 when running
Raw command: /usr/bin/make testformat1-html

Whats the purpose of the linesBetween function?
And the start & endDelms?

[agander]

@simonmichael, any chance of a nudge in in the right direction?
'<' is obviously part of the delimiter, so maybe its failing because of that.

While trying to use ptrace in linesBetween it fails with:

No instance for (Show  ([Char]  -> ParsecT String u0 Data.Functor.Identity.Identity String))

So, do I need to write a Show instance?

[simonmichael]

@agander from the trace I can see it's failing to parse format 2, failing to parse format 3, parsing format 1 as far as the command (echo a) and input (Nothing), but seems to be going wrong parsing the output:

at line  2 col  1: ">>>\n<a>\n>>>2\n>>>= 0\n\n"               format1test o: Nothing

It should be Just "<a>\n" or similar.

Also I see that --debug-parse/--debug/showParserDebugOutput are not wired up very well, I guess you had to change code to enable that trace. I think --debug=2 is supposed to work but the --debug option is not currently allowing an argument (it does in hledger).

[simonmichael]

Because linesmatcher is consuming the < I think, perhaps it needs a try.

>>> parse linesmatcher1 "" "<a>\n"
Left (line 1, column 1):
unexpected "a"
expecting "<<<"

[simonmichael]

Fix to code and yesterday's test coming, hope I'm not stepping on your toes.