add CI #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

simonmichael merged 1 commit into simonmichael:master from obfusk:fix-ci

May 22, 2020

Contributor

obfusk commented May 17, 2020

No description provided.


          add CI

2252e0d

Owner

simonmichael commented May 22, 2020

Wonderful, thank you very much! Merging this one first.

simonmichael merged commit 396b6e6 into simonmichael:master

Owner

simonmichael commented May 22, 2020

I notice that CI is passing even though its final make test command currently returns a failing exit code. This seems odd, shouldn't it fail ?

Owner

simonmichael commented May 22, 2020

In fact, I see CI is passing even with failing tests: https://github.com/simonmichael/shelltestrunner/runs/700752600

Contributor Author

obfusk commented May 22, 2020 •

edited

Loading

Well, there's 1 test that's expected to fail: running the bash test with /bin/sh: https://github.com/simonmichael/shelltestrunner/blob/7e4e86d/Makefile#L75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet