Skip to content

improve bash tests & fix extra-source-files #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented May 23, 2020

Fixes #13.

@simonmichael simonmichael merged commit a245112 into simonmichael:master Aug 18, 2020
@simonmichael
Copy link
Owner

Thanks!

@simonmichael
Copy link
Owner

@obfusk I found the failing test output with sh confusing. What's the reason for testing the non-bash shell here, would it make sense if I drop it ?

@obfusk
Copy link
Contributor Author

obfusk commented Aug 18, 2020

@obfusk I found the failing test output with sh confusing. What's the reason for testing the non-bash shell here, would it make sense if I drop it ?

I thought it best to make the expected behaviour (i.e. failure) with a non-bash shell explicit.
It would also make sure the test results are not misleading should they be run on a system where /bin/sh behaves differently.

@simonmichael
Copy link
Owner

We have observed that this bash-specific test fails with non-bash, but I don't really see that as property we need to test and guarantee. Maybe sh changes some day and that test starts passing, should we care and report that as a failure ? I'm inclined to remove it for now.

@obfusk
Copy link
Contributor Author

obfusk commented Aug 19, 2020

We've already seen what happens when someone uses bash as their normal shell and (not unreasonably) expects certain syntax like $'...' to work (#15).

If, for example, you have a system where /bin/sh behaves exactly like /bin/bash then the bash-only test not failing will tell you that your assumptions about "normal behaviour" for /bin/sh may be wrong. (I've been bitten by some bugs caused by subtle differences in behaviour between Linux and *BSD regarding e.g. bash and wc before, hence my -- perhaps unnecessary -- caution here.)

Having said that: since this is a faily minor concern, I'm happy to defer to your judgement :)

@simonmichael
Copy link
Owner

simonmichael commented Aug 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract test files missing from sdist
2 participants