Skip to content

Use AS5600 auto increment suppress #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

tikonen
Copy link

@tikonen tikonen commented Apr 19, 2025

This IC does not increment I2C read pointer when the angle is read for performance reasons. There is no need to rewrite the register address on an every request.

This makes angle query practically almost twice as fast. I've tested this only on AS5600 so feature is disabled by default for other I2C comms based sensors.

This IC does not increment I2C read pointer when the angle is read so there is no need to rewrite it on a every request.
@runger1101001 runger1101001 changed the base branch from master to dev April 21, 2025 14:11
@runger1101001
Copy link
Member

runger1101001 commented Apr 21, 2025

Hi @tikonen , thank you for contributing this but actually we already support this in our dedicated driver for the AS5600:

https://github.com/simplefoc/Arduino-FOC-drivers/tree/master/src/encoders/as5600

This driver additionally keeps the I2C transactions open and in my tests achieves significantly higher read rates than our regular driver.
It also has the advantage of being able to read/write the sensors other registers.
So I think I’d prefer to keep the MagneticSensorI2C driver really basic and free of hardware-specific functions, since we have the dedicated drivers for the people who want them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants