Add Ruby 3.2 support for rspec_api_documentation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kceb
commented
Feb 8, 2024
| @@ -5,7 +5,7 @@ module Writers | |||
| class AppendJsonWriter < JsonWriter | |||
| def write | |||
| index_file = docs_dir.join("index.json") | |||
| if File.exists?(index_file) && (output = File.read(index_file)).length >= 2 | |||
There was a problem hiding this comment.
File.exists? is deprecated in 3.2
https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/
kceb
requested review from
krasnoukhov,
EnotPoloskun,
arettberg,
pdoulatshahi and
caseykim
|
@EnotPoloskun regarding your comment here: I don't see an associated branch in this repo 🤔 , so I am making this to |
caseykim
approved these changes
Feb 10, 2024
pdoulatshahi
approved these changes
Feb 12, 2024
arettberg
reviewed
Feb 20, 2024
jfadgen
approved these changes
Apr 8, 2024
|
🤦♂️ I clicked the default merge option and forgot to switch to squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/186997377