agent: fix message delivery in case one of the connections has no snd queue for any reason - it could break delivery to all connections #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… queue for any reason - it could break delivery to all connections
epoberezkin
force-pushed
the
ep/fix-delivery
branch
from
374556e to
a7c217d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change delays failing with CONN SIMPLEX error until later, to make sure that connections that reference the message body can use it. While this does not address the unknown root cause of CONN SIMPLEX error, it compensates for it, allowing delivery in case the first connection happens to be CONN SIMPLEX (which can be any connection, as we sort them randomly, and it resulted in complete failure to deliver some messages to the groups)