Fix problem with the CLI never exiting (#69)

Fixes #53
Fixes #68

Author: chinesedfan

index.js

@@ -1,6 +1,7 @@
 'use strict';
 const path = require('path');
 const isUrl = require('is-url-superb');
+const isGithubUrl = require('is-github-url');
 const ora = require('ora');
 const remark = require('remark');
 const gitClone = require('git-clone');
@@ -34,9 +35,23 @@ const lint = options => {
 
 lint.report = async options => {
 	const spinner = ora('Linting').start();
+
+	try {
+		await lint._report(options, spinner);
+	} catch (error) {
+		spinner.fail(error.message);
+		process.exitCode = 1;
+	}
+};
+
+lint._report = async (options, spinner) => {
 	let temp = null;
 
 	if (isUrl(options.filename)) {
+		if (!isGithubUrl(options.filename, {repository: true})) {
+			throw new Error(`Invalid GitHub repo URL: ${options.filename}`);
+		}
+
 		temp = tempy.directory();
 		await pify(gitClone)(options.filename, temp);
 

package.json

@@ -44,6 +44,7 @@
 		"github-url-to-object": "^4.0.4",
 		"globby": "^9.0.0",
 		"got": "^9.6.0",
+		"is-github-url": "^1.2.2",
 		"is-url-superb": "^2.0.0",
 		"mdast-util-to-string": "^1.0.4",
 		"meow": "^5.0.0",

test/cli.js

@@ -7,3 +7,17 @@ test('main', async t => {
 		/Missing Awesome badge/
 	);
 });
+
+test('main - non-existent file', async t => {
+	await t.throwsAsync(
+		execa.stderr('./cli.js', ['test/fixtures/non-existent.md']),
+		/Couldn't find the file/
+	);
+});
+
+test('main - invalid GitHub repository', async t => {
+	await t.throwsAsync(
+		execa.stderr('./cli.js', ['https://github.com/sindresorhus/awesome-lint/blob/master/readme.md']),
+		/Invalid GitHub repo URL/
+	);
+});