Fix problem with the CLI never exiting #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think we want to support other git repos in addition to GitHub. |
Contributor
|
I think we should add some tests to make sure this works (and continues to work) as expected. |
Contributor
Author
|
@transitive-bullshit Maybe in future. See #53 (comment). @itaisteinherz Right. After the scope is confirmed, I will add tests. |
Collaborator
|
@chinesedfan sounds good 😄 |
Co-Authored-By: chinesedfan <[email protected]>
Contributor
Author
|
@sindresorhus Updated. Thanks for your reviews and feel shame for my silly mistakes. |
Collaborator
No reason to feel any shame -- we all make mistakes 😀 Thanks a lot for your contributions so far! I think just fixing one small typo and this PR is good to go. |
sindresorhus
changed the title
Owner
|
Can you fix the merge conflict? |
Contributor
Author
|
@sindresorhus Conflict resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53 and fixes #68.