Skip to content

Fix problem with the CLI never exiting #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 19, 2019
Merged

Fix problem with the CLI never exiting #69

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f5d3117
Fix never exit when an error was thrown
chinesedfan Mar 27, 2019
7b73fdf
Throw error if url is not valid Github repository
chinesedfan Mar 27, 2019
6534319
Fix lint and undefined error
chinesedfan Mar 28, 2019
099cebb
Add test and fix regexp
chinesedfan Mar 29, 2019
8a3dfc7
Replace with is-github-url
chinesedfan Mar 29, 2019
d8117a8
Update invalid error message
sindresorhus Apr 1, 2019
7b85159
Fix typos
chinesedfan Apr 1, 2019
58c8aac
Fix file name typo
chinesedfan Apr 8, 2019
71b7fe0
Merge branch 'master' into fix-exit
chinesedfan Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ const vfileReporterPretty = require('vfile-reporter-pretty');
const config = require('./config');
const findReadmeFile = require('./lib/find-readme-file');

const rGithubRepo = /^https:\/\/github\.com\/[^/]+\/[^/]+$/;

const lint = options => {
options = {
config,
Expand All @@ -34,9 +36,23 @@ const lint = options => {

lint.report = async options => {
const spinner = ora('Linting').start();

try {
await lint._report(options, spinner);
} catch (error) {
spinner.fail(error.message);
process.exitCode = 1;
}
};

lint._report = async (options, spinner) => {
let temp = null;

if (isUrl(options.filename)) {
if (!rGithubRepo.test(options.filename)) {
throw new Error(`Invalid Github repository url: ${options.filename}`);
}

temp = tempy.directory();
await pify(gitClone)(options.filename, temp);

Expand Down
14 changes: 14 additions & 0 deletions test/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,17 @@ test('main', async t => {
/Missing Awesome badge/
);
});

test('main - non-exsitent file', async t => {
await t.throwsAsync(
execa.stderr('./cli.js', ['test/fixtures/non-exsitent.md']),
/Couldn't find the file/
);
});

test('main - invalid Github repository', async t => {
await t.throwsAsync(
execa.stderr('./cli.js', ['https://github.com/sindresorhus/awesome-lint/blob/master/readme.md']),
/Invalid Github repository url/
);
});