Skip to content

Add reporter option #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 13, 2019
Merged

Add reporter option #55

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ab80d63
Allow user to pass in custom reporter
Jan 11, 2019
476c884
Linting
Jan 18, 2019
f1dfc7a
Bump minor version
Jan 18, 2019
2cbb3d1
Update index.js
sindresorhus Feb 11, 2019
acb4b48
Respond to feedback
Feb 11, 2019
a1aaccf
Add tests and update readme for reporter option
Feb 11, 2019
b60de42
Add reporter option to cli
Feb 11, 2019
4890b0b
Update api.js
sindresorhus Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ lint.report = async options => {

if (messages.length === 0) {
spinner.succeed();
if (options.customReporter) {
console.log(options.customReporter([]));
}

return;
}

Expand All @@ -69,7 +73,11 @@ lint.report = async options => {
process.exitCode = 1;

file.path = path.basename(file.path);
console.log(vfileReporterPretty([file]));
if (options.customReporter) {
Copy link
Owner

@sindresorhus sindresorhus Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option name can simply be named reporter.

console.log(options.customReporter([file]));
} else {
console.log(vfileReporterPretty([file]));
}
Copy link
Owner

@sindresorhus sindresorhus Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified to:

const reporter = options.reporter || vfileReporterPretty;
console.log(reporter([file]));

};

module.exports = lint;
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "awesome-lint",
"version": "0.8.0",
"version": "0.9.0",
Copy link
Owner

@sindresorhus sindresorhus Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't bump version in a pull request. It's up to the maintainers when, how, and what version to bump :)

Copy link
Contributor Author

@damccorm damccorm Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my apologies, that makes sense.

"description": "Linter for Awesome lists",
"license": "MIT",
"repository": "sindresorhus/awesome-lint",
Expand Down