Allow emoji or image after the entry description #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Overall, looks really solid. See my comment in #60 as Sindre has the final call on all formatting decisions like this. |
Owner
lib/trim-emoji.js
Outdated
| const emoji = match[0]; | ||
| const codePoints = [...emoji].length; | ||
| if (match.index === 0) { | ||
| text = text.substr(codePoints).trim(); |
Owner
There was a problem hiding this comment.
I would prefer using slice instead of substr.
Contributor
Author
There was a problem hiding this comment.
Sure. But sadly you rejected this feature, #60 (comment).
lib/trim-emoji.js
Outdated
| } | ||
| } | ||
|
|
||
| return text; |
Owner
There was a problem hiding this comment.
Why not just text.replace(emojiRegex, '')?
Contributor
Author
There was a problem hiding this comment.
See my test cases. I want to trim emojis and spaces, but NOT to remove inner emojis and NOT to trim spaces if no emojis.
- t.deepEqual(trimEmoji('⭐ hello'), 'hello');
- t.deepEqual(trimEmoji(' hello '), ' hello ');
- t.deepEqual(trimEmoji('hello⭐hello'), 'hello⭐hello');
Collaborator
|
@chinesedfan can you update this PR to reflect the decision made in #60? Thanks! |
Contributor
Author
|
@transitive-bullshit Updated. |
transitive-bullshit
changed the title
Owner
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60.
In fact, emoji was allowed after the entry description by #29.