Skip to content

Conversation

@itaisteinherz
Copy link
Contributor

@itaisteinherz itaisteinherz commented Mar 28, 2019

The awesome/heading rule lints all of the given file's headings, verifying that:

  • There is exactly one heading.
  • It's in title case.
  • It's children array is flat (i.e. it doesn't have any nested and complicated child elements).

Fixes #59

@itaisteinherz itaisteinherz changed the title Add awesome/heading Add rule awesome/heading Mar 28, 2019
Copy link
Collaborator

@transitive-bullshit transitive-bullshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR generally looks solid @itaisteinherz.

In addition to my small inline comment, I'd like to fix #75 before merging just to be sure that it won't have any unintended side effects.

@itaisteinherz
Copy link
Contributor Author

@transitive-bullshit Any chance you could take another look at this? 🙃

@sindresorhus
Copy link
Owner

I'd like to fix #75 before merging just to be sure that it won't have any unintended side effects.

Ideally, I would agree, but #75 is still not fixed and it cannot block all other work forever.

@sindresorhus sindresorhus merged commit bce4a90 into sindresorhus:master Jun 15, 2019
@itaisteinherz itaisteinherz deleted the ensure-heading-case branch June 15, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure the list heading is in title case, not slug case

3 participants