Add rule for GitHub #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transitive-bullshit
requested changes
Apr 7, 2019
Collaborator
transitive-bullshit
left a comment
transitive-bullshit
left a comment
There was a problem hiding this comment.
This implementation looks really solid @TiagoDanin 😄
Just one small piece of feedback.
Also, I'd like to resolve #75 before merging to see how new rules like this will affect existing awesome lists.
Thanks!!
Collaborator
|
I think this is good to merge after updating the message text. @sindresorhus any thoughts on this or #75? |
transitive-bullshit
approved these changes
Apr 8, 2019
Collaborator
|
Thanks again @TiagoDanin! |
Owner
|
Does this completely fix #41? |
Collaborator
|
I believe so. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related in #41 👍