Skip to content

Conversation

@chinesedfan
Copy link
Contributor

Closed #54.

Notice that I switched to dashes, instead of colons. Or we need to update unified-lint-rule. Please tell me if you insist. @sindresorhus @transitive-bullshit

function factory(id, rule) {
  var parts = id.split(':') // if `id` was `remark-lint:awesome:badge`, then wrong `ruleId` was got
  var source = parts[0]
  var ruleId = parts[1]
  ... ...

@chinesedfan
Copy link
Contributor Author

@sindresorhus @transitive-bullshit Friendly ping. As well as #76.

@sindresorhus
Copy link
Owner

Can you document the special comment feature in the readme and link to remarks or something where the user can read more about.

@chinesedfan
Copy link
Contributor Author

@sindresorhus Updated.

@chinesedfan
Copy link
Contributor Author

@sindresorhus I have tried my best to add a new section to introduce this feature. You can revise as you wish.

@chinesedfan
Copy link
Contributor Author

@sindresorhus @transitive-bullshit Hello, are there something need me to update? As well as #76, again.

@peaceiris
Copy link

Thank you for implementing a nice feature!

@sindresorhus
Copy link
Owner

I'm not ignoring this PR, I've just been too busy.

@sindresorhus
Copy link
Owner

@chinesedfan Can you do the / => - change to ddbebd1 too?

@chinesedfan
Copy link
Contributor Author

@sindresorhus Updated. Really understand your busy and appreciate your help on my PR.

@sindresorhus sindresorhus merged commit fe139d8 into sindresorhus:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ignoring blocks of the readme

3 participants