`prefer-global-this` should ignore `typeof window === 'undefined'`

[belgattitude]

Hey thanks for the plugin, it's so useful !

I recently updated to v56 and was surprised about the autofix

It's very common to have

const isServer = typeof window === 'undefined';
const isBrowser = typeof window !== 'undefined'

It fixes to

const isServer = typeof globalThis === 'undefined';
const isBrowser = typeof globalThis !== 'undefined';

Which isn't valid

Interested to know your advices.

PS: Thanks to @fregant comment below: window' in globalThis

[fregante]

Yeah this sounds like it should be an exception.

For now you can disable the rule inline or use 'window' in globalThis and then !isBrowser

[belgattitude]

If there isn’t any drawbacks, would it be possible to consider your suggested code in the autofix ?

how could we proceed. For me this issue looks a dealbreaker

[zanminkian]

const isBrowser = () => 'window' in globalThis should work. I don't recommend using window or self object, unless the using apis belong to them.

[axetroy]

typeof window is a shorthand way of writing typeof globalThis.window

So it should not emit an error. This seems reasonable. same as self