Add consistent-assert rule
#2535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jan 22, 2025
docs/rules/consistent-assert.md
Outdated
| <!-- end auto-generated rule header --> | ||
| <!-- Do not manually modify this header. Run: `npm run fix:eslint-docs` --> | ||
|
|
||
| Enforce consistent assertion styles with `node:assert`. |
There was a problem hiding this comment.
This is just repeating the title.
docs/rules/consistent-assert.md
Outdated
| assert(true); | ||
|
|
||
| // ✅ | ||
| assert.ok(true); |
There was a problem hiding this comment.
It's not clear from the examples why assert.ok is better than assert.
fisker
reviewed
Jan 22, 2025
rules/consistent-assert.js
Outdated
Comment on lines
53
to
56
| const variable = scope.variables.find(variable => variable.name === specifier.local.name); | ||
| if (!variable) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const variable = scope.variables.find(variable => variable.name === specifier.local.name); | |
| if (!variable) { | |
| continue; | |
| } | |
| const variable = sourceCode.getDeclaredVariables(specifier); |
fisker
reviewed
Jan 22, 2025
rules/consistent-assert.js
Outdated
|
|
||
| // Skip if the identifier is not part of a call expression | ||
| // Skip if the identifier is the object of a member expression | ||
| if (!isFunctionCall() || isMemberExpression()) { |
There was a problem hiding this comment.
Shouldn't we only check function call?
axetroy
force-pushed
the
consistent-assert
branch
from
1ededac to
90cf41d
Compare
axetroy
force-pushed
the
consistent-assert
branch
from
90cf41d to
ee60f09
Compare
This reverts commit fbd95cf1a34da1ccf37d8a412db124c999b6ce96.
fisker
reviewed
Jan 22, 2025
|
@axetroy Pushed some changes, mainly |
fisker
approved these changes
Jan 23, 2025
fisker
reviewed
Jan 23, 2025
fisker
reviewed
Jan 23, 2025
docs/rules/consistent-assert.md
Outdated
| ``` | ||
|
|
||
| ```js | ||
| import assert from 'node:assert/strict'; |
There was a problem hiding this comment.
The node:assert/strict module should be encouraged to use, let's move this one to top.
Co-authored-by: fisker Cheung <[email protected]>
rules/consistent-assert.js
Outdated
| meta: { | ||
| type: 'problem', | ||
| docs: { | ||
| description: 'Enforce consistent assertion styles with `node:assert`', |
There was a problem hiding this comment.
Suggested change
| description: 'Enforce consistent assertion styles with `node:assert`', | |
| description: 'Enforce consistent assertion styles with `node:assert`.', |
docs/rules/consistent-assert.md
Outdated
| @@ -0,0 +1,51 @@ | |||
| # Enforce consistent assertion styles with `node:assert` | |||
There was a problem hiding this comment.
Suggested change
| # Enforce consistent assertion styles with `node:assert` | |
| # Enforce consistent assertion style with `node:assert` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1806