Remove Object.prototype properties from builtin and `es*` globals #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sindresorhus merged 5 commits into sindresorhus:main from fisker:object-properties

Mar 25, 2024

Collaborator

fisker commented Feb 22, 2024

These properties are accessible in global scope, but I don't think it make sense to list them here.

fisker added 2 commits

February 22, 2024 14:46


          Remove Object.prototype properties from builtin globals

1073c58


          Update logic

fe2aff7

fisker changed the title ~~Remove Object.prototype properties from builtin globals~~ Remove Object.prototype properties from builtin and es* globals


          Remove from es5

5d3bb81

fisker marked this pull request as draft

February 22, 2024 07:18

Collaborator Author

fisker commented Feb 22, 2024 •

edited

Loading

I read #3 and #5 again, looks like it's indented behavior, should we reconsider?

ESLint v9 will be released soon, may be reasonable to include this change.

Owner

sindresorhus commented Mar 24, 2024

I'm in favor of removing them. No one should be using those.

fisker added 2 commits

March 25, 2024 16:25


          Merge branch 'main' into object-properties

31e4eb2

# Conflicts:
#	scripts/update.mjs


          Run build

08ffcd6

fisker marked this pull request as ready for review

March 25, 2024 08:32

sindresorhus merged commit 753b2b2 into sindresorhus:main

fisker deleted the object-properties branch

March 25, 2024 18:28

fisker mentioned this pull request

feat: add Intl in es6 globals eslint/eslint#18318

Merged

1 task

Stanislav1975 mentioned this pull request

[Snyk] Upgrade globals from 13.24.0 to 15.8.0 Stanislav1975/eslint#6

Open

renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request


          fix(deps): update dependency globals to v15

1c879f3

##### [v15.9.0](sindresorhus/globals@v15.8.0...b1d88b8)

##### [v15.8.0](sindresorhus/globals@v15.7.0...f6b3978)

##### [v15.7.0](https://github.com/sindresorhus/globals/releases/tag/v15.7.0)

-   Update globals ([#255](sindresorhus/globals#255))  [`f017b0f`](sindresorhus/globals@f017b0f)
##### [v15.6.0](https://github.com/sindresorhus/globals/releases/tag/v15.6.0)

-   Add Chai globals ([#247](sindresorhus/globals#247))  [`9b0c591`](sindresorhus/globals@9b0c591)
##### [v15.5.0](https://github.com/sindresorhus/globals/releases/tag/v15.5.0)

-   Update globals ([#254](sindresorhus/globals#254))  [`19ea4cf`](sindresorhus/globals@19ea4cf)
##### [v15.4.0](https://github.com/sindresorhus/globals/releases/tag/v15.4.0)

-   Add globals for every yearly es versions ([#252](sindresorhus/globals#252))  [`45c1b17`](sindresorhus/globals@45c1b17)
##### [v15.3.0](https://github.com/sindresorhus/globals/releases/tag/v15.3.0)

-   Update globals ([#251](sindresorhus/globals#251))  [`90b42e5`](sindresorhus/globals@90b42e5)
##### [v15.2.0](https://github.com/sindresorhus/globals/releases/tag/v15.2.0)

-   Add AudioWorklet globals ([#249](sindresorhus/globals#249))  [`7d163e3`](sindresorhus/globals@7d163e3)
##### [v15.1.0](https://github.com/sindresorhus/globals/releases/tag/v15.1.0)

-   Update ([#246](sindresorhus/globals#246))  [`fa21dea`](sindresorhus/globals@fa21dea)
##### [v15.0.0](https://github.com/sindresorhus/globals/releases/tag/v15.0.0)

##### Breaking

-   Remove `Object.prototype` properties from builtin and `es*` globals ([#237](sindresorhus/globals#237))  [`753b2b2`](sindresorhus/globals@753b2b2)

##### Improvements

-   Add many missing globals sindresorhus/globals@v14.0.0...v15.0.0#diff-69f22d314a4ed7807a4f6eee8d91b4ec6c09b11cb13ce9d16e53fd163c5ca151

##### Meta

-   Generate data programmatically ([#219](sindresorhus/globals#219))  [`0a02e03`](sindresorhus/globals@0a02e03)

***

Big thanks to [@fisker](https://github.com/fisker) for all these improvements!

***

renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request


          fix(deps): update dependency globals to v15

a4887cc

##### [v15.9.0](sindresorhus/globals@v15.8.0...b1d88b8)

##### [v15.8.0](sindresorhus/globals@v15.7.0...f6b3978)

##### [v15.7.0](https://github.com/sindresorhus/globals/releases/tag/v15.7.0)

-   Update globals ([#255](sindresorhus/globals#255))  [`f017b0f`](sindresorhus/globals@f017b0f)
##### [v15.6.0](https://github.com/sindresorhus/globals/releases/tag/v15.6.0)

-   Add Chai globals ([#247](sindresorhus/globals#247))  [`9b0c591`](sindresorhus/globals@9b0c591)
##### [v15.5.0](https://github.com/sindresorhus/globals/releases/tag/v15.5.0)

-   Update globals ([#254](sindresorhus/globals#254))  [`19ea4cf`](sindresorhus/globals@19ea4cf)
##### [v15.4.0](https://github.com/sindresorhus/globals/releases/tag/v15.4.0)

-   Add globals for every yearly es versions ([#252](sindresorhus/globals#252))  [`45c1b17`](sindresorhus/globals@45c1b17)
##### [v15.3.0](https://github.com/sindresorhus/globals/releases/tag/v15.3.0)

-   Update globals ([#251](sindresorhus/globals#251))  [`90b42e5`](sindresorhus/globals@90b42e5)
##### [v15.2.0](https://github.com/sindresorhus/globals/releases/tag/v15.2.0)

-   Add AudioWorklet globals ([#249](sindresorhus/globals#249))  [`7d163e3`](sindresorhus/globals@7d163e3)
##### [v15.1.0](https://github.com/sindresorhus/globals/releases/tag/v15.1.0)

-   Update ([#246](sindresorhus/globals#246))  [`fa21dea`](sindresorhus/globals@fa21dea)
##### [v15.0.0](https://github.com/sindresorhus/globals/releases/tag/v15.0.0)

##### Breaking

-   Remove `Object.prototype` properties from builtin and `es*` globals ([#237](sindresorhus/globals#237))  [`753b2b2`](sindresorhus/globals@753b2b2)

##### Improvements

-   Add many missing globals sindresorhus/globals@v14.0.0...v15.0.0#diff-69f22d314a4ed7807a4f6eee8d91b4ec6c09b11cb13ce9d16e53fd163c5ca151

##### Meta

-   Generate data programmatically ([#219](sindresorhus/globals#219))  [`0a02e03`](sindresorhus/globals@0a02e03)

***

Big thanks to [@fisker](https://github.com/fisker) for all these improvements!

***

renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request


          fix(deps): update dependency globals to v15

78d3c3f

##### [v15.9.0](sindresorhus/globals@v15.8.0...b1d88b8)

##### [v15.8.0](sindresorhus/globals@v15.7.0...f6b3978)

##### [v15.7.0](https://github.com/sindresorhus/globals/releases/tag/v15.7.0)

-   Update globals ([#255](sindresorhus/globals#255))  [`f017b0f`](sindresorhus/globals@f017b0f)
##### [v15.6.0](https://github.com/sindresorhus/globals/releases/tag/v15.6.0)

-   Add Chai globals ([#247](sindresorhus/globals#247))  [`9b0c591`](sindresorhus/globals@9b0c591)
##### [v15.5.0](https://github.com/sindresorhus/globals/releases/tag/v15.5.0)

-   Update globals ([#254](sindresorhus/globals#254))  [`19ea4cf`](sindresorhus/globals@19ea4cf)
##### [v15.4.0](https://github.com/sindresorhus/globals/releases/tag/v15.4.0)

-   Add globals for every yearly es versions ([#252](sindresorhus/globals#252))  [`45c1b17`](sindresorhus/globals@45c1b17)
##### [v15.3.0](https://github.com/sindresorhus/globals/releases/tag/v15.3.0)

-   Update globals ([#251](sindresorhus/globals#251))  [`90b42e5`](sindresorhus/globals@90b42e5)
##### [v15.2.0](https://github.com/sindresorhus/globals/releases/tag/v15.2.0)

-   Add AudioWorklet globals ([#249](sindresorhus/globals#249))  [`7d163e3`](sindresorhus/globals@7d163e3)
##### [v15.1.0](https://github.com/sindresorhus/globals/releases/tag/v15.1.0)

-   Update ([#246](sindresorhus/globals#246))  [`fa21dea`](sindresorhus/globals@fa21dea)
##### [v15.0.0](https://github.com/sindresorhus/globals/releases/tag/v15.0.0)

##### Breaking

-   Remove `Object.prototype` properties from builtin and `es*` globals ([#237](sindresorhus/globals#237))  [`753b2b2`](sindresorhus/globals@753b2b2)

##### Improvements

-   Add many missing globals sindresorhus/globals@v14.0.0...v15.0.0#diff-69f22d314a4ed7807a4f6eee8d91b4ec6c09b11cb13ce9d16e53fd163c5ca151

##### Meta

-   Generate data programmatically ([#219](sindresorhus/globals#219))  [`0a02e03`](sindresorhus/globals@0a02e03)

***

Big thanks to [@fisker](https://github.com/fisker) for all these improvements!

***

renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request


          fix(deps): update dependency globals to v15

eccec34

##### [v15.9.0](sindresorhus/globals@v15.8.0...b1d88b8)

##### [v15.8.0](sindresorhus/globals@v15.7.0...f6b3978)

##### [v15.7.0](https://github.com/sindresorhus/globals/releases/tag/v15.7.0)

-   Update globals ([#255](sindresorhus/globals#255))  [`f017b0f`](sindresorhus/globals@f017b0f)
##### [v15.6.0](https://github.com/sindresorhus/globals/releases/tag/v15.6.0)

-   Add Chai globals ([#247](sindresorhus/globals#247))  [`9b0c591`](sindresorhus/globals@9b0c591)
##### [v15.5.0](https://github.com/sindresorhus/globals/releases/tag/v15.5.0)

-   Update globals ([#254](sindresorhus/globals#254))  [`19ea4cf`](sindresorhus/globals@19ea4cf)
##### [v15.4.0](https://github.com/sindresorhus/globals/releases/tag/v15.4.0)

-   Add globals for every yearly es versions ([#252](sindresorhus/globals#252))  [`45c1b17`](sindresorhus/globals@45c1b17)
##### [v15.3.0](https://github.com/sindresorhus/globals/releases/tag/v15.3.0)

-   Update globals ([#251](sindresorhus/globals#251))  [`90b42e5`](sindresorhus/globals@90b42e5)
##### [v15.2.0](https://github.com/sindresorhus/globals/releases/tag/v15.2.0)

-   Add AudioWorklet globals ([#249](sindresorhus/globals#249))  [`7d163e3`](sindresorhus/globals@7d163e3)
##### [v15.1.0](https://github.com/sindresorhus/globals/releases/tag/v15.1.0)

-   Update ([#246](sindresorhus/globals#246))  [`fa21dea`](sindresorhus/globals@fa21dea)
##### [v15.0.0](https://github.com/sindresorhus/globals/releases/tag/v15.0.0)

##### Breaking

-   Remove `Object.prototype` properties from builtin and `es*` globals ([#237](sindresorhus/globals#237))  [`753b2b2`](sindresorhus/globals@753b2b2)

##### Improvements

-   Add many missing globals sindresorhus/globals@v14.0.0...v15.0.0#diff-69f22d314a4ed7807a4f6eee8d91b4ec6c09b11cb13ce9d16e53fd163c5ca151

##### Meta

-   Generate data programmatically ([#219](sindresorhus/globals#219))  [`0a02e03`](sindresorhus/globals@0a02e03)

***

Big thanks to [@fisker](https://github.com/fisker) for all these improvements!

***

renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request


          fix(deps): update dependency globals to v15

ed8d29e

##### [v15.9.0](sindresorhus/globals@v15.8.0...b1d88b8)

##### [v15.8.0](sindresorhus/globals@v15.7.0...f6b3978)

##### [v15.7.0](https://github.com/sindresorhus/globals/releases/tag/v15.7.0)

-   Update globals ([#255](sindresorhus/globals#255))  [`f017b0f`](sindresorhus/globals@f017b0f)
##### [v15.6.0](https://github.com/sindresorhus/globals/releases/tag/v15.6.0)

-   Add Chai globals ([#247](sindresorhus/globals#247))  [`9b0c591`](sindresorhus/globals@9b0c591)
##### [v15.5.0](https://github.com/sindresorhus/globals/releases/tag/v15.5.0)

-   Update globals ([#254](sindresorhus/globals#254))  [`19ea4cf`](sindresorhus/globals@19ea4cf)
##### [v15.4.0](https://github.com/sindresorhus/globals/releases/tag/v15.4.0)

-   Add globals for every yearly es versions ([#252](sindresorhus/globals#252))  [`45c1b17`](sindresorhus/globals@45c1b17)
##### [v15.3.0](https://github.com/sindresorhus/globals/releases/tag/v15.3.0)

-   Update globals ([#251](sindresorhus/globals#251))  [`90b42e5`](sindresorhus/globals@90b42e5)
##### [v15.2.0](https://github.com/sindresorhus/globals/releases/tag/v15.2.0)

-   Add AudioWorklet globals ([#249](sindresorhus/globals#249))  [`7d163e3`](sindresorhus/globals@7d163e3)
##### [v15.1.0](https://github.com/sindresorhus/globals/releases/tag/v15.1.0)

-   Update ([#246](sindresorhus/globals#246))  [`fa21dea`](sindresorhus/globals@fa21dea)
##### [v15.0.0](https://github.com/sindresorhus/globals/releases/tag/v15.0.0)

##### Breaking

-   Remove `Object.prototype` properties from builtin and `es*` globals ([#237](sindresorhus/globals#237))  [`753b2b2`](sindresorhus/globals@753b2b2)

##### Improvements

-   Add many missing globals sindresorhus/globals@v14.0.0...v15.0.0#diff-69f22d314a4ed7807a4f6eee8d91b4ec6c09b11cb13ce9d16e53fd163c5ca151

##### Meta

-   Generate data programmatically ([#219](sindresorhus/globals#219))  [`0a02e03`](sindresorhus/globals@0a02e03)

***

Big thanks to [@fisker](https://github.com/fisker) for all these improvements!

***

renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request


          fix(deps): update dependency globals to v15

368bcc4

##### [v15.9.0](sindresorhus/globals@v15.8.0...b1d88b8)

##### [v15.8.0](sindresorhus/globals@v15.7.0...f6b3978)

##### [v15.7.0](https://github.com/sindresorhus/globals/releases/tag/v15.7.0)

-   Update globals ([#255](sindresorhus/globals#255))  [`f017b0f`](sindresorhus/globals@f017b0f)
##### [v15.6.0](https://github.com/sindresorhus/globals/releases/tag/v15.6.0)

-   Add Chai globals ([#247](sindresorhus/globals#247))  [`9b0c591`](sindresorhus/globals@9b0c591)
##### [v15.5.0](https://github.com/sindresorhus/globals/releases/tag/v15.5.0)

-   Update globals ([#254](sindresorhus/globals#254))  [`19ea4cf`](sindresorhus/globals@19ea4cf)
##### [v15.4.0](https://github.com/sindresorhus/globals/releases/tag/v15.4.0)

-   Add globals for every yearly es versions ([#252](sindresorhus/globals#252))  [`45c1b17`](sindresorhus/globals@45c1b17)
##### [v15.3.0](https://github.com/sindresorhus/globals/releases/tag/v15.3.0)

-   Update globals ([#251](sindresorhus/globals#251))  [`90b42e5`](sindresorhus/globals@90b42e5)
##### [v15.2.0](https://github.com/sindresorhus/globals/releases/tag/v15.2.0)

-   Add AudioWorklet globals ([#249](sindresorhus/globals#249))  [`7d163e3`](sindresorhus/globals@7d163e3)
##### [v15.1.0](https://github.com/sindresorhus/globals/releases/tag/v15.1.0)

-   Update ([#246](sindresorhus/globals#246))  [`fa21dea`](sindresorhus/globals@fa21dea)
##### [v15.0.0](https://github.com/sindresorhus/globals/releases/tag/v15.0.0)

##### Breaking

-   Remove `Object.prototype` properties from builtin and `es*` globals ([#237](sindresorhus/globals#237))  [`753b2b2`](sindresorhus/globals@753b2b2)

##### Improvements

-   Add many missing globals sindresorhus/globals@v14.0.0...v15.0.0#diff-69f22d314a4ed7807a4f6eee8d91b4ec6c09b11cb13ce9d16e53fd163c5ca151

##### Meta

-   Generate data programmatically ([#219](sindresorhus/globals#219))  [`0a02e03`](sindresorhus/globals@0a02e03)

***

Big thanks to [@fisker](https://github.com/fisker) for all these improvements!

***

renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request


          fix(deps): update dependency globals to v15

ac859cd

##### [v15.9.0](sindresorhus/globals@v15.8.0...b1d88b8)

##### [v15.8.0](sindresorhus/globals@v15.7.0...f6b3978)

##### [v15.7.0](https://github.com/sindresorhus/globals/releases/tag/v15.7.0)

-   Update globals ([#255](sindresorhus/globals#255))  [`f017b0f`](sindresorhus/globals@f017b0f)
##### [v15.6.0](https://github.com/sindresorhus/globals/releases/tag/v15.6.0)

-   Add Chai globals ([#247](sindresorhus/globals#247))  [`9b0c591`](sindresorhus/globals@9b0c591)
##### [v15.5.0](https://github.com/sindresorhus/globals/releases/tag/v15.5.0)

-   Update globals ([#254](sindresorhus/globals#254))  [`19ea4cf`](sindresorhus/globals@19ea4cf)
##### [v15.4.0](https://github.com/sindresorhus/globals/releases/tag/v15.4.0)

-   Add globals for every yearly es versions ([#252](sindresorhus/globals#252))  [`45c1b17`](sindresorhus/globals@45c1b17)
##### [v15.3.0](https://github.com/sindresorhus/globals/releases/tag/v15.3.0)

-   Update globals ([#251](sindresorhus/globals#251))  [`90b42e5`](sindresorhus/globals@90b42e5)
##### [v15.2.0](https://github.com/sindresorhus/globals/releases/tag/v15.2.0)

-   Add AudioWorklet globals ([#249](sindresorhus/globals#249))  [`7d163e3`](sindresorhus/globals@7d163e3)
##### [v15.1.0](https://github.com/sindresorhus/globals/releases/tag/v15.1.0)

-   Update ([#246](sindresorhus/globals#246))  [`fa21dea`](sindresorhus/globals@fa21dea)
##### [v15.0.0](https://github.com/sindresorhus/globals/releases/tag/v15.0.0)

##### Breaking

-   Remove `Object.prototype` properties from builtin and `es*` globals ([#237](sindresorhus/globals#237))  [`753b2b2`](sindresorhus/globals@753b2b2)

##### Improvements

-   Add many missing globals sindresorhus/globals@v14.0.0...v15.0.0#diff-69f22d314a4ed7807a4f6eee8d91b4ec6c09b11cb13ce9d16e53fd163c5ca151

##### Meta

-   Generate data programmatically ([#219](sindresorhus/globals#219))  [`0a02e03`](sindresorhus/globals@0a02e03)

***

Big thanks to [@fisker](https://github.com/fisker) for all these improvements!

***

renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request


          fix(deps): update dependency globals to v15

5705c15

##### [v15.9.0](sindresorhus/globals@v15.8.0...b1d88b8)

##### [v15.8.0](sindresorhus/globals@v15.7.0...f6b3978)

##### [v15.7.0](https://github.com/sindresorhus/globals/releases/tag/v15.7.0)

-   Update globals ([#255](sindresorhus/globals#255))  [`f017b0f`](sindresorhus/globals@f017b0f)
##### [v15.6.0](https://github.com/sindresorhus/globals/releases/tag/v15.6.0)

-   Add Chai globals ([#247](sindresorhus/globals#247))  [`9b0c591`](sindresorhus/globals@9b0c591)
##### [v15.5.0](https://github.com/sindresorhus/globals/releases/tag/v15.5.0)

-   Update globals ([#254](sindresorhus/globals#254))  [`19ea4cf`](sindresorhus/globals@19ea4cf)
##### [v15.4.0](https://github.com/sindresorhus/globals/releases/tag/v15.4.0)

-   Add globals for every yearly es versions ([#252](sindresorhus/globals#252))  [`45c1b17`](sindresorhus/globals@45c1b17)
##### [v15.3.0](https://github.com/sindresorhus/globals/releases/tag/v15.3.0)

-   Update globals ([#251](sindresorhus/globals#251))  [`90b42e5`](sindresorhus/globals@90b42e5)
##### [v15.2.0](https://github.com/sindresorhus/globals/releases/tag/v15.2.0)

-   Add AudioWorklet globals ([#249](sindresorhus/globals#249))  [`7d163e3`](sindresorhus/globals@7d163e3)
##### [v15.1.0](https://github.com/sindresorhus/globals/releases/tag/v15.1.0)

-   Update ([#246](sindresorhus/globals#246))  [`fa21dea`](sindresorhus/globals@fa21dea)
##### [v15.0.0](https://github.com/sindresorhus/globals/releases/tag/v15.0.0)

##### Breaking

-   Remove `Object.prototype` properties from builtin and `es*` globals ([#237](sindresorhus/globals#237))  [`753b2b2`](sindresorhus/globals@753b2b2)

##### Improvements

-   Add many missing globals sindresorhus/globals@v14.0.0...v15.0.0#diff-69f22d314a4ed7807a4f6eee8d91b4ec6c09b11cb13ce9d16e53fd163c5ca151

##### Meta

-   Generate data programmatically ([#219](sindresorhus/globals#219))  [`0a02e03`](sindresorhus/globals@0a02e03)

***

Big thanks to [@fisker](https://github.com/fisker) for all these improvements!

***

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet