-
-
Notifications
You must be signed in to change notification settings - Fork 135
Closed
Description
Folders in the options.ignore list are not ignored if they have a trailing forward slash.
/
├── ignore-first/
| └── file.txt
└── ignore-second/
└── file.txt
options.ignore:
['ignore-first/', 'ignore-second']
ignore-first is not ignored in the folders list, while ignore-second is indeed ignored.
dir-glob allows specifying a cwd option as well, which is used by it to determine if an entry in the ignore list is actually a directory or not (https://github.com/kevva/dir-glob/blob/dc6e7978a641fd1e8e4329ba474fb0af65b52519/index.js#L64); this is defaulted to process.cwd(), which doesn't mark such entries as actual directories in the generated glob list.
This can be fixed by passing the original cwd option to dir-glob below:
Line 105 in 7807d29
| options.ignore = dirGlob.sync(options.ignore); |
edit: fixed typos and formatting
Metadata
Metadata
Assignees
Labels
No labels