Set default value for an options object

[mrmlnc]

Hello,

I ran into a problem that after the client extension by the .extend method, the init hook gets an undefined instead of an object as options.

The following example illustrates the problem.

const got = require('got').default;

const client = got.extend({
	hooks: {
		init: [
			(options) => {
				console.dir({ options }, { colors: true });
			}
		]
	}
});

(async () => {
	await client('https://google.com'); // { options: undefined }
	await client('https://google.com', {}); // { options: {} }
	await client({ url: 'https://google.com' }); // { options: { url: <value> }}
})();

Looks like a bug, because I see that the init hook should get an Options object according to the signature in the types.

got/source/core/index.ts

Line 103 in 87dadd5

export type InitHook = (options: Options) => void;

So, this PR fixes the problem. If you accept this change, I can make a backport to the v11 branch.

Checklist

• I have read the documentation.
• I have included a pull request description of my changes.
• I have included some tests.
• If it's a new feature, I have included documentation updates in both the README and the types.

[mrmlnc]

Looks like CI fails due to last update of node.js. Works fine under 12.18.4 and breaks after 12.19.0.

  Uncaught exception in test/timeout.ts

  Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
  Please open an issue with this stack trace at https://github.com/nodejs/node/issues


  › Please open an issue with this stack trace at https://github.com/nodejs/node/issues
  › assert (internal/assert.js:14:11)
  › TCP.onStreamRead (internal/stream_base_commons.js:188:23)

[szmarczak]

@mrmlnc Can you please open another issue for this?