Preserve request body on cross-origin 307 and 308 redirects#2460
Merged
Conversation
307 and 308 must preserve the request method and body per RFC 9110, even across origins. Got was dropping the body on cross-origin redirects, producing a POST with an empty body, which matched neither the spec nor a GET conversion and diverged from every other client (browsers, undici, curl, ky all preserve the body and strip only credentials). Fixes #2459
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
307 and 308 must preserve the request method and body per RFC 9110, even across origins. Got was dropping the body on cross-origin redirects, producing a POST with an empty body, which matched neither the spec nor a GET conversion and diverged from every other client (browsers, undici, curl, ky all preserve the body and strip only credentials).
Fixes #2459