Refactor module in TypeScript #28

ltetzlaff · 2017-10-31T23:38:58Z

According to #9 I setup the typescript compiler, added typings where appropriate, otherwise any and configured the ignores so that npm will contain index.d.ts and index.js and github index.ts.

Due to index.js being "volatile" compiled code I had to drop xo (sorry Sindre) because the style of the compiled code can't be configured

Also some keywords are reserved (null, function, class) and needed to be merged into the declaration via Object.assign(), see keywords issue.

Code compiled from ts to js does not match xo-standard and cannot be configured.

sindresorhus · 2017-11-01T07:38:34Z

index.ts

@@ -0,0 +1,237 @@
+const util = require('util');
+
+//const toString = Object.prototype.toString;


sindresorhus · 2017-11-01T07:40:22Z

tsconfig.json

+{
+    "compileOnSave": true,
+    "compilerOptions": {
+        "target": "es6",


Just set it to es5 and we can use any ES6 feature, regardless of having to support Node.js 4.

The problem is with new Set(), which is perfectly used but typescript won't provide a polyfill for es5 during the transpilation, so I would suggest to ponyfill with array and Array.indexOf or an associative Object? 😦

Should work if you specify:

"lib": [ "es2015" ],

sindresorhus · 2017-11-01T07:47:26Z

tsconfig.json

+        "outDir": ".",
+        "noImplicitAny": true,
+        "suppressImplicitAnyIndexErrors": true
+    },


We should create a source map file too, for better debugging experience.

sindresorhus · 2017-11-01T07:48:23Z

tsconfig.json

+    ],
+    "exclude": [
+        "node_modules"
+    ]


Excluding node_modules is already the default.

sindresorhus · 2017-11-01T07:53:02Z

Due to index.js being "volatile" compiled code I had to drop xo (sorry Sindre) because the style of the compiled code can't be configured

No worries

sindresorhus · 2017-11-01T07:53:11Z

Thanks for working on this @ltetzlaff :)

sindresorhus · 2017-11-01T07:48:43Z

index.ts

+	};
+}
+
+// Some few keywords are reserved


Can you link to the TS issue here in a comment?

sindresorhus · 2017-11-01T07:49:37Z

index.ts

+	export const even = isAbsoluteMod2(0);
+	export const odd = isAbsoluteMod2(1);
+
+	const isWhiteSpaceString = (x: any) => is.string(x) && /\S/.test(x) === false;


Let's use a better name than x, since it will show up in auto-completion. We can use value instead.

for all methods?

Yes, anywhere x is used now.

sindresorhus · 2017-11-01T07:50:02Z

index.ts

+		}
+
+		if (is.array(range) && range.length === 2) {
+			// TODO: Use spread operator here when targeting Node.js 6 or higher


When you target es5 in the tsconfig, you can fix this TODO.

sindresorhus · 2017-11-01T07:51:19Z

.npmignore

@@ -0,0 +1 @@
+index.ts


This is not needed as we're using the files property in package.json

sindresorhus · 2017-11-01T07:56:19Z

Does it really make sense to export each method as an individual export? I'm just asking. Because without the is word, the readability suffers.

import {string} from 'is';

...

string('🦄');

vs

import is from 'is';

...

is.string('🦄');

You could, of course, do this, but I doubt most will:

import {string as isString} from 'is';

...

isString('🦄');

sindresorhus · 2017-11-01T10:42:39Z

Due to index.js being "volatile" compiled code I had to drop xo (sorry Sindre) because the style of the compiled code can't be configured

I published a TSLint config which we can use.

Just run npm i --save-dev tslint tslint-xo and add a tslint.json file to the repo root with:

{
     "extends": "tslint-xo"
}

And the following to scripts in package.json:

"lint": "tslint --project .",

sindresorhus · 2017-11-01T11:35:22Z

tsconfig.json

+        "declaration": true,
+        "outDir": ".",
+        "noImplicitAny": true,
+        "suppressImplicitAnyIndexErrors": true


sindresorhus · 2017-11-01T11:36:26Z

tsconfig.json

+        "alwaysStrict": true,
+        "declaration": true,
+        "outDir": ".",
+        "noImplicitAny": true,


This is not needed. It's included in the strict option.

sindresorhus · 2017-11-01T11:39:59Z

index.ts

+	export const falsy = (x: any) => !x;
+
+	// the tests are designed for Number.isNaN rather than global isNaN
+	export const nan = (x: any) => is.number(x) && isNaN(Number(x)); 


Why did you change this from the original?

Number.isNaN is currently not supported and isNaN() is typeguarded to only accept number
see microsoft/TypeScript#15149

Ok. Maybe you can use // @ts-ignore on it? https://blogs.msdn.microsoft.com/typescript/2017/10/31/announcing-typescript-2-6/

If not, at least link to the TS issue in a comment above.

SamVerschueren

Went through the code and have added a first feedback round.

Some extra things.

I believe we should add the TS files to a directory called source and use dist as output directory. Will make it more easy to maintain in the future when extracting things to separate files.

We should also write the tests in TypeScript so that the entire codebase is TypeScript.

I also agree with @sindresorhus regarding the default export. We should go for import is from '@sindresorhus/is';.

SamVerschueren · 2017-11-01T07:49:10Z

.gitignore

@@ -1,2 +1,5 @@
 node_modules
 yarn.lock
+
+index.js
+index.d.ts


Add final newline

SamVerschueren · 2017-11-01T12:30:33Z

index.ts

@@ -0,0 +1,237 @@
+const util = require('util');


import * as util from 'util';

SamVerschueren · 2017-11-01T12:31:01Z

index.ts

+
+//const toString = Object.prototype.toString;
+const getObjectType = (x: any) => toString.call(x).slice(8, -1) as string;
+const isOfType = (type: string) => (x: any) => typeof x === type; // eslint-disable-line valid-typeof


Remove eslint-disable-line comment

SamVerschueren · 2017-11-01T12:31:28Z

index.ts

+const isObjectOfType = (type: string) => (x: any) => getObjectType(x) === type;
+
+//export default is
+function is (value: any) {


Remove space before function paren

SamVerschueren · 2017-11-01T12:35:31Z

index.ts

+	export const arrayBuffer = isObjectOfType('ArrayBuffer');
+	export const sharedArrayBuffer = isObjectOfType('SharedArrayBuffer');
+
+	export const truthy = (x: any) => !!x; // eslint-disable-line no-implicit-coercion


Remove eslint-disable-line comment.

@sindresorhus Would it be better to use Boolean(x) here?

SamVerschueren · 2017-11-01T12:36:36Z

index.ts

+	export const plainObject = (x: any) => {
+		// From: https://github.com/sindresorhus/is-plain-obj/blob/master/index.js
+		let prototype;
+		// eslint-disable-next-line no-return-assign


Remove eslint-disable-next-line comment.

SamVerschueren · 2017-11-01T12:39:52Z

index.ts

+	// We have to use anonymous functions for the any() and all() methods
+	// to get the arguments since we can't use rest parameters in node v4.
+	export const any = function (predicate: any) {
+		return predicateOnArray(Array.prototype.some, predicate, arguments);


TS supports rest parameters.

SamVerschueren · 2017-11-01T12:40:03Z

index.ts

+	};
+
+	export const all = function (predicate: any) {
+		return predicateOnArray(Array.prototype.every, predicate, arguments);


Same as above, you can use rest parameters.

SamVerschueren · 2017-11-01T12:42:53Z

tsconfig.json

+    "exclude": [
+        "node_modules"
+    ]
+}


Add final newline

ltetzlaff · 2017-11-02T01:41:38Z

Hi guys, thanks a lot for pointing out those changes, I'm really glad to contribute here.
I've covered the suggestions and refactored the tests file.

Now there are several points that introduce some difficulties, for instance:

is.class

Fails on classes because TS-es5 makes functions out of it.

Example

var Foo = /** @class */ (function () {
		function Foo() {
		}
		return Foo;
}());
var classDeclarations = [
		Foo,
		/** @class */ (function (_super) {
				__extends(Bar, _super);
				function Bar() {
						return _super !== null && _super.apply(this, arguments) || this;
				}
				return Bar;
		}(Foo))
];

is.plainObject

Fails on generators because TS-es5 makes plainObjects out of it.

Example

var __generator = (this && this.__generator) || function (thisArg, body) {
	var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g;
	return g = { next: verb(0), "throw": verb(1), "return": verb(2) }, typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g;
	function verb(n) { return function (v) { return step([n, v]); }; }
	function step(op) {
...

is.generatorFunction

Fails as well.

Example

return __generator(this, function (_a) {
		switch (_a.label) {
				case 0: return [4 /*yield*/, 4];
				case 1:
						_a.sent();
						return [2 /*return*/];
		}
});

Tomorrow i'll get back to adding tslint-xo, thx for adding that Sindre 👍

sindresorhus · 2017-11-02T02:34:29Z

.gitignore

@@ -1,2 +1,4 @@
 node_modules
 yarn.lock
+dist/**/*.js*
+dist/**/*.d.ts


I would just ignore the whole directory instead:

dist

ltetzlaff · 2017-11-02T12:23:44Z

Yay, next round:

Node 4 Build fails:

Destructuring

/home/travis/build/sindresorhus/is/node_modules/jsdom/lib/api.js:10
const { URL } = require("whatwg-url");
      ^
SyntaxError: Unexpected token {

Should we drop jsdom and use something that supports Node 4? Do you maybe have anything specific in mind @sindresorhus ?

Node 8 Build fails:

Typescript builds async functions to return this:

var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
    return new (P || (P = Promise))(function (resolve, reject) {
        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
        function step(result) { result.done ? resolve(result.value) : new P(function (resolve) { resolve(result.value); }).then(fulfilled, rejected); }
        step((generator = generator.apply(thisArg, _arguments || [])).next());
    });
};

Should we drop the test or add an OR-condition that matches the typescript-generated?

SamVerschueren · 2017-11-02T13:20:12Z

.gitignore

@@ -1,2 +1,3 @@
 node_modules
 yarn.lock
+dist/


Add final newline. Just use dist without /.

I recommend installing an editorconfig plugin for your text editor. Things like final newlines will then be added automatically.

Yea, thanks for the hint, was just about time to give my dotfiles a refresh 👍

SamVerschueren · 2017-11-02T13:20:42Z

package.json

+    "lint": "tslint --project .",
+    "build": "tsc",
+    "test": "npm run lint && npm run build && ava dist/tests",
+    "prepublish": "npm run build"
  },
  "files": [


Just set it to dist.

SamVerschueren · 2017-11-02T13:21:45Z

tslint.json

@@ -0,0 +1,3 @@
+{
+	"extends": "tslint-xo"
+}


Final newline

SamVerschueren · 2017-11-02T13:28:31Z

src/index.ts

@@ -0,0 +1,231 @@
+import * as util from 'util';


Rename the directory from src to source. @sindresorhus and I agreed upon this name in another project.

SamVerschueren · 2017-11-02T13:32:33Z

tests/test.ts

-import test from 'ava';
-import {jsdom} from 'jsdom';
-import m from '.';
+import * as util from 'util';


I'd rather put the tests directory into the source directory. This way, everything regarding code sits together. This also means that the index.ts file is compiled to dist/index.js which seems a little better than dist/src/index.js.

The only thing that should be done then is in the prepublish hook. Install del-cli as dev dependency and set this as prepublish script.

npm run build && del dist/tests

SamVerschueren · 2017-11-02T13:34:08Z

tests/test.ts


-const document = jsdom();
-const createDomElement = el => document.createElement(el);
+/* This ensures a certain method matches only the types


Make comment single line

SamVerschueren · 2017-11-02T13:44:01Z

tsconfig.json

+    "compilerOptions": {
+        /* es2015 requires moduleResolution and module to be set, 
+        see https://github.com/Microsoft/TypeScript/issues/8189 */
+        "target": "es2015",


@sindresorhus Might have missed this, but didn't we want to target ES5?

@SamVerschueren Can't: #28 (comment)

sindresorhus · 2017-11-02T14:24:47Z

Should we drop jsdom and use something that supports Node 4? Do you maybe have anything specific in mind @sindresorhus ?

Don't upgrade jsdom. The existing version was outdated exactly for this reason, to keep Node.js 4 support.

sindresorhus · 2017-11-02T14:25:52Z

Should we drop the test or add an OR-condition that matches the typescript-generated?

Just comment out the test until we can figure out a solution for it.

sindresorhus · 2017-11-03T08:38:32Z

@ltetzlaff Any thoughts on #28 (comment) ?

gioragutt · 2017-11-03T17:14:07Z

src/index.ts

+
+	export const promise = (value: any) => nativePromise(value) || hasPromiseAPI(value);
+
+	// TODO: Change to use `isObjectOfType` once Node.js 6 or higher is targeted


Can this be used now?

no, the comment is still valid because the restricting factor is node runtime here

gioragutt · 2017-11-03T17:20:59Z

tests/test.ts

+	['undefined',
+		{is: m.undefined, fixtures: [undefined]}
+	], ['null',
+		{is: m.null_, fixtures: [null]}


Why not m.null? Isn't the whole purpose of Lines 225-229 in the source file to allow that?

It does work when using it in js but Typescript can't find a type definition for that due to it being added via defineProperties 😞
I know it is not optimal, do you have a better idea or a method that merges the namespace with reserved keywords here?
Unfortunately @ts-ignore did not work out in that case.

gioragutt · 2017-11-03T17:25:33Z

tests/test.ts

+const document = new jsdom.JSDOM().window.document;
+const createDomElement = (el: string) => document.createElement(el);
+
+interface Test {is(value: any): boolean; fixtures: any[]; }


spread this to

interface Test { is: (value: any) => boolean; fixtures: any[]; }

and add a new-line after that

gioragutt · 2017-11-03T17:29:05Z

tests/test.ts

+	], ['symbol',
+		{is: m.symbol, fixtures: [Symbol('🦄')]}
+	], ['array',
+		{is: m.array, fixtures: [[1, 2], new Array(2)]} // tslint:disable-line:prefer-array-literal


There are multiple fixtures and this is a single line.
I'm fine with single-lining if there's only one fixture, although I'd rather consistency overall,
Meaning that each type would look like:

['typename', { is: m.typename, fixtures: [ // there can be one or more fixtures here, but this would be consistent, as there are currently // tests with one fixture which are one lined, but also some that're multiple fixtures but also one lined ]} ]

Agreed, makes perfect sense

gioragutt · 2017-11-03T17:31:37Z

tests/test.ts

+
+	if (testData === undefined) {
+		t.fail('is.object not defined');
+


remove this empty line

The linter config insists on that empty line before return, sry 👍

ltetzlaff · 2017-11-03T19:56:12Z

Don't upgrade jsdom. The existing version was outdated exactly for this reason, to keep Node.js 4 support.

Alright, I updated because I did not find typings for that version, but going after the date I found that package version [email protected] goes together with @types/[email protected]. which in turn reenables Node 4 🎉

ltetzlaff · 2017-11-03T20:41:33Z

@ltetzlaff Any thoughts on #28 (comment) ?

Yes, I agree, is makes sense as a module so we should not export every member of the namespace.

I'd go for enabling both

import is from 'is';

as well as

import {is} from 'is';

sindresorhus · 2017-11-03T20:49:13Z

I'd go for enabling both

Why? I prefer one way to do something.

ltetzlaff · 2017-11-03T20:54:36Z

Why? I prefer one way to do something.

Since there is only one export shall we go for default export then?

import is from 'is';

Either using the code from before the ts-refactors or writing something that will match both our runtime targets and still provides type/ide support by using type overloads

ltetzlaff

Alright, I think I covered everything you reviewed, sorry that so many things came up 😅

sindresorhus · 2017-11-04T03:53:28Z

Since there is only one export shall we go for default export then?

Yes

SamVerschueren · 2017-11-04T12:05:48Z

package.json

  },
+  "main": "dist",


Add "typings": "dist/index.d.ts" here as well. Not sure if needed in the main field though, but I always point to the index.js file explicitely.

"main": "dist/index.js", "typings": "dist/index.d.ts",

SamVerschueren · 2017-11-04T12:11:03Z

source/tests/test.ts

 import {jsdom} from 'jsdom';
-import m from '.';
+import m from '..'; // tslint:disable-line:import-name


The rule is disabled in [email protected] so you can remove the comment.

SamVerschueren · 2017-11-04T12:13:05Z

source/tests/test.ts

+	fixtures: any[];
+}
+
+const types = new Map<string, Test>([


In terms of readability, I would rather see it formatted like this

const types = new Map<string, Test>([ ['undefined', { is: m.undefined, fixtures: [ undefined ] }], ['null', { is: m.null_, fixtures: [ null ] }], ['string', { is: m.string, fixtures: [ '🦄', 'hello world', '' ] }] // ... ]);

SamVerschueren · 2017-11-04T12:13:44Z

source/tests/test.ts

-// it's supposed to and none of the other methods' types
-const testType = (t, type, exclude) => {
-	for (const [key, value] of types) {
+/* This ensures a certain method matches only the types


One-line comment

SamVerschueren · 2017-11-04T12:25:37Z

source/tests/test.ts

+
+	const {is} = testData;
+
+	types.forEach(({fixtures}, key) => {


Use a for..of instead (like it was).

for (const [key, {fixtures}] of types) { // TODO: Automatically exclude value types in other tests that we have in the current one. // Could reduce the use of `exclude`. if (exclude && exclude.indexOf(key) !== -1) { continue; } const assert = key === type ? t.true.bind(t) : t.false.bind(t); for (const fixture of fixtures) { assert(is(fixture), `Value: ${util.inspect(fixture)}`); } }

Also, there's the comment about the exclude, we can use types.filter to get rid of it

not unless we do Array.from(types).filter() since types is a Map, but feel free to do so, If you feel that that would be an improvement ✌️

SamVerschueren · 2017-11-05T20:02:43Z

source/tests/test.ts

-	['undefined',
-		{is: m.undefined, fixtures: [
+	['undefined', {
+		is: m.undefined, fixtures: [


Put fixtures on a newline as well.

SamVerschueren · 2017-11-05T20:03:10Z

package.json

  },
+  "main": "dist/index",


dist/index.js

SamVerschueren · 2017-11-05T20:03:17Z

package.json

  },
+  "main": "dist/index",
+  "types": "dist/index",


dist/index.d.ts

ltetzlaff · 2017-11-06T11:47:37Z

What's your preferred way of distributing this library?

distributing ts and compiling locally
distributing only pure js, declaration and source map
npm vs gh?

SamVerschueren · 2017-11-06T11:49:54Z

distributing only pure js, declaration and source map

sindresorhus · 2017-11-06T15:27:39Z

Landed. Thanks for all the hard work you put into this @ltetzlaff. We really appreciate it 🙌

gioragutt · 2017-11-06T16:40:51Z

Amazing work @ltetzlaff, seriously.

ltetzlaff · 2017-11-07T00:02:15Z

Thanks for your words, I really enjoyed contributing to you guys. 🎉 😃

ltetzlaff added 5 commits October 31, 2017 16:23

Setup Typescript, ignores and compiler options

d85736e

Remove index.js from git index

3bd1579

Refactor whole module in Typescript for #9

aaafb59

Drop xo for style checking

d870cee

Code compiled from ts to js does not match xo-standard and cannot be configured.

Remove destructuring for Node 4 to work

19a450b

sindresorhus requested review from SamVerschueren, brandon93s and gioragutt November 1, 2017 07:35

sindresorhus reviewed Nov 1, 2017

View reviewed changes

index.ts Outdated

@@ -0,0 +1,237 @@

const util = require('util');

//const toString = Object.prototype.toString;

Copy link

Owner

sindresorhus Nov 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

sindresorhus reviewed Nov 1, 2017

View reviewed changes

tsconfig.json Outdated

],

"exclude": [

"node_modules"

]

Copy link

Owner

sindresorhus Nov 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluding node_modules is already the default.

Update .gitignore

fa82c36

sindresorhus changed the title ~~Refactor whole module in Typescript~~ Refactor module in TypeScript Nov 1, 2017

sindresorhus requested changes Nov 1, 2017

View reviewed changes

sindresorhus reviewed Nov 1, 2017

View reviewed changes

SamVerschueren suggested changes Nov 1, 2017

View reviewed changes

ltetzlaff added 5 commits November 1, 2017 22:27

Add suggested changes from review

53302ff

Refactor every parameter to value instead of x

a9f4ca3

Move index.ts and adapt settings to folders

0118e26

Update jsdom and typings

a5e5f68

Rework test suite

00bbbb0

sindresorhus reviewed Nov 2, 2017

View reviewed changes

Fix files in package.json

c4fc587

SamVerschueren suggested changes Nov 2, 2017

View reviewed changes

gioragutt requested changes Nov 3, 2017

View reviewed changes

ltetzlaff added 4 commits November 3, 2017 21:58

Add suggestions from review and downgrade jsdom

1eae6af

comment out test that fails due to typescript target

4670dcf

remove every spread operator

9879728

Either using the code from before the ts-refactors or writing something that will match both our runtime targets and still provides type/ide support by using type overloads

Add main field to package.json

eed20f5

ltetzlaff commented Nov 3, 2017

View reviewed changes

SamVerschueren suggested changes Nov 4, 2017

View reviewed changes

ltetzlaff added 2 commits November 5, 2017 04:29

Bump tslint-xo and add main/types field

fae6e0d

Change formatting and swap forEach with for..of

d119d62

SamVerschueren suggested changes Nov 5, 2017

View reviewed changes

Make main fields more verbose, change indentation

bc3825b

SamVerschueren approved these changes Nov 6, 2017

View reviewed changes

sindresorhus merged commit 8d8fd2b into sindresorhus:master Nov 6, 2017

sindresorhus mentioned this pull request Nov 7, 2017

Use TypeScript #9

Closed

		@@ -0,0 +1,237 @@
		const util = require('util');

		//const toString = Object.prototype.toString;


		export const promise = (value: any) => nativePromise(value) \|\| hasPromiseAPI(value);

		// TODO: Change to use `isObjectOfType` once Node.js 6 or higher is targeted


		if (testData === undefined) {
		t.fail('is.object not defined');

Uh oh!

Refactor module in TypeScript #28

Refactor module in TypeScript #28

Uh oh!

Conversation

ltetzlaff commented Oct 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ltetzlaff Nov 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sindresorhus commented Nov 1, 2017

Uh oh!

sindresorhus commented Nov 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sindresorhus Nov 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sindresorhus commented Nov 1, 2017

Uh oh!

sindresorhus commented Nov 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SamVerschueren left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ltetzlaff commented Oct 31, 2017 •

edited

Loading

ltetzlaff Nov 1, 2017 •

edited

Loading

sindresorhus Nov 1, 2017 •

edited

Loading

sindresorhus commented Nov 1, 2017 •

edited

Loading

ltetzlaff commented Nov 2, 2017 •

edited

Loading

ltetzlaff commented Nov 2, 2017 •

edited

Loading